Skip to content

Commit 844eff2

Browse files
authored
Merge pull request #7581 from Prajyot-Parab/main
✨ Introduce additional linters & bump golangci-lint to 1.50.1
2 parents 9a2f9b5 + 354d5b0 commit 844eff2

File tree

3 files changed

+4
-2
lines changed

3 files changed

+4
-2
lines changed

.github/workflows/golangci-lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,5 +25,5 @@ jobs:
2525
- name: golangci-lint
2626
uses: golangci/golangci-lint-action@0ad9a0988b3973e851ab0a07adf248ec2e100376 # tag=v3.3.1
2727
with:
28-
version: v1.50.0
28+
version: v1.50.1
2929
working-directory: ${{matrix.working-directory}}

.golangci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ linters:
4141
- nilerr
4242
- noctx
4343
- nolintlint
44+
- nosprintfhostport
4445
- prealloc
4546
- predeclared
4647
- revive
@@ -52,6 +53,7 @@ linters:
5253
- unconvert
5354
- unparam
5455
- unused
56+
- usestdlibvars
5557
- whitespace
5658

5759
linters-settings:

cmd/clusterctl/client/repository/goproxy.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ func (g *goproxyClient) getVersions(ctx context.Context, base, owner, repository
7474
}
7575
defer resp.Body.Close()
7676

77-
if resp.StatusCode != 200 {
77+
if resp.StatusCode != http.StatusOK {
7878
retryError = errors.Errorf("failed to get versions: response status code %d", resp.StatusCode)
7979
return false, nil
8080
}

0 commit comments

Comments
 (0)