Revert "Fix RemoveOwnerRef so that it does not mutate its input"

dlipovetsky · dlipovetsky · commit 938359d7172a · 2022-09-29T10:37:27.000-07:00
This reverts commit da5da78bf6f972e7cc2dc1f10f750a8df65df8a9.
diff --git a/util/util.go b/util/util.go
@@ -326,8 +326,7 @@ func ReplaceOwnerRef(ownerReferences []metav1.OwnerReference, source metav1.Obje
 // RemoveOwnerRef returns the slice of owner references after removing the supplied owner ref.
 func RemoveOwnerRef(ownerReferences []metav1.OwnerReference, inputRef metav1.OwnerReference) []metav1.OwnerReference {
 	if index := indexOwnerRef(ownerReferences, inputRef); index != -1 {
-		copyOwnerReferences := append([]metav1.OwnerReference{}, ownerReferences...)
-		return append(copyOwnerReferences[:index], copyOwnerReferences[index+1:]...)
+		return append(ownerReferences[:index], ownerReferences[index+1:]...)
 	}
 	return ownerReferences
 }

Original file line number	Diff line number	Diff line change
`@@ -326,8 +326,7 @@ func ReplaceOwnerRef(ownerReferences []metav1.OwnerReference, source metav1.Obje`
`326`	`326`	`// RemoveOwnerRef returns the slice of owner references after removing the supplied owner ref.`
`327`	`327`	`func RemoveOwnerRef(ownerReferences []metav1.OwnerReference, inputRef metav1.OwnerReference) []metav1.OwnerReference {`
`328`	`328`	`if index := indexOwnerRef(ownerReferences, inputRef); index != -1 {`
`329`		`- copyOwnerReferences := append([]metav1.OwnerReference{}, ownerReferences...)`
`330`		`- return append(copyOwnerReferences[:index], copyOwnerReferences[index+1:]...)`
	`329`	`+ return append(ownerReferences[:index], ownerReferences[index+1:]...)`
`331`	`330`	`}`
`332`	`331`	`return ownerReferences`
`333`	`332`	`}`