Make v1beta1 APIEndpoint host & port fields optional to fix v1beta1 e2e test

Author: sbueringer

api/core/v1beta1/cluster_types.go

@@ -1092,12 +1092,12 @@ func (c *ClusterStatus) GetTypedPhase() ClusterPhase {
 type APIEndpoint struct {
 	// host is the hostname on which the API server is serving.
 	// TODO: Can't set MinLength=1 for now, because this struct is not always used in pointer fields so today we have cases where host is set to an empty string.
-	// +required
+	// +optional
 	// +kubebuilder:validation:MaxLength=512
 	Host string `json:"host"`
 
 	// port is the port on which the API server is serving.
-	// +required
+	// +optional
 	Port int32 `json:"port"`
 }
 

api/core/v1beta1/zz_generated.openapi.go

@@ -101,9 +101,9 @@
         - [Best practices](./developer/providers/best-practices.md)
         - [Security guidelines](./developer/providers/security-guidelines.md)
         - [Version migration](developer/providers/migrations/overview.md)
-          - [v1.8 to v1.9](./developer/providers/migrations/v1.8-to-v1.9.md)
           - [v1.9 to v1.10](./developer/providers/migrations/v1.9-to-v1.10.md)
           - [v1.10 to v1.11](./developer/providers/migrations/v1.10-to-v1.11.md)        
+          - [v1.11 to v1.12](./developer/providers/migrations/v1.11-to-v1.12.md)        
 - [Troubleshooting](./user/troubleshooting.md)
 - [Reference](./reference/reference.md)
     - [API Reference](./reference/api/reference.md)

config/crd/bases/cluster.x-k8s.io_clusters.yaml

@@ -0,0 +1,29 @@
+# Cluster API v1.11 compared to v1.12
+
+This document provides an overview over relevant changes between Cluster API v1.11 and v1.12 for
+maintainers of providers and consumers of our Go API.
+
+## Go version
+
+- The Go version used by Cluster API is Go 1.24.x
+
+## Changes by Kind
+
+### Deprecation
+
+### Removals
+
+### API Changes
+
+### Other
+
+### Suggested changes for providers
+
+* For providers that copied the core Cluster API v1beta1 `APIEndpoint` struct and used it in their InfraCluster Go type 
+  it is recommended to now make the `Host` and `Port` fields optional (they already have been made optional in 
+  `clusterv1beta1.APIEndpoint` in Cluster API v1.12).
+  tl;dr The fields were previously required, but due to side effects that validation was never enforced. These side
+  effects might go away which then makes the fields suddenly required. To avoid issues we recommend making the fields
+  optional. Similar to how they are optional in the v1beta2 `APIEndpoint` struct and v1beta2 InfraCluster contract.
+  For more details, please see: https://github.com/kubernetes-sigs/cluster-api/pull/12634#discussion_r2275468291.
+  But this might look differently depending on how your InfraCluster Go type and corresponding mutating webhook evolved over time.

docs/book/src/SUMMARY.md

@@ -116,10 +116,12 @@ type DockerClusterV1Beta2Status struct {
 // APIEndpoint represents a reachable Kubernetes API endpoint.
 type APIEndpoint struct {
 	// Host is the hostname on which the API server is serving.
+	// +optional
 	Host string `json:"host"`
 
 	// Port is the port on which the API server is serving.
 	// Defaults to 6443 if not set.
+	// +optional
 	Port int `json:"port"`
 }