Adjust KAL config to exclude requiredfields false positives

Author: sbueringer

.golangci-kal.yml

@@ -212,6 +212,10 @@ linters:
       text: "requiredfields: field .* is marked as required, but has the omitempty tag"
       linters:
         - kubeapilinter
+    - path: "api/.*"
+      text: "requiredfields: field (Applied|Value|Layout|RetryCount|Required|Prefix|TimeoutSeconds) is marked as required, should not be a pointer"
+      linters:
+        - kubeapilinter
 
     # TODO: Excludes that should be removed once https://github.com/kubernetes-sigs/kube-api-linter/issues/132 will be fixed
     - path: "api/.*"
@@ -222,6 +226,7 @@ linters:
       text: "optionalfields: field (.*) is optional and has a valid zero value \\({}\\), but the validation is not complete \\(e.g. min properties/adding required fields\\). The field should be a pointer to allow the zero value to be set. If the zero value is not a valid use case, complete the validation and remove the pointer."
       linters:
         - kubeapilinter
+
 issues:
   max-same-issues: 0
   max-issues-per-linter: 0

internal/controllers/clusterclass/clusterclass_controller_test.go

@@ -203,7 +203,7 @@ func assertStatusVariables(actualClusterClass *clusterv1.ClusterClass) error {
 				return errors.Errorf("ClusterClass spec or status variable %s is nil, expected both to be set", specVar.Name)
 			}
 			if *specVar.Required != *statusVarDefinition.Required {
-				return errors.Errorf("ClusterClass status variable %s required field does not match. Expected %v. Got %v", specVar.Name, statusVarDefinition.Required, statusVarDefinition.Required)
+				return errors.Errorf("ClusterClass status variable %s required field does not match. Expected %v. Got %v", specVar.Name, *statusVarDefinition.Required, *statusVarDefinition.Required)
 			}
 			if !cmp.Equal(specVar.Schema, statusVarDefinition.Schema) {
 				return errors.Errorf("ClusterClass status variable %s schema does not match. Expected %v. Got %v", specVar.Name, specVar.Schema, statusVarDefinition.Schema)