Merge pull request #7208 from oscr/more-linters-more-fun

✨ Enable linters: asasalint, bidichk, durationcheck, errchkjson. Fix findings

Author: k8s-ci-robot

.golangci.yml

@@ -1,12 +1,16 @@
 linters:
   disable-all: true
   enable:
+  - asasalint
   - asciicheck
+  - bidichk
   - bodyclose
   - containedctx
   - depguard
   - dogsled
+  - durationcheck
   - errcheck
+  - errchkjson
   - exportloopref
   - gci
   - goconst

docs/Dockerfile

@@ -18,7 +18,7 @@
 FROM maven:3-jdk-8
 
 RUN apt-get update && apt-get install -y --no-install-recommends graphviz=2.42.2-5 fonts-symbola=2.60-1.1 fonts-wqy-zenhei=0.9.45-8 && rm -rf /var/lib/apt/lists/*
-RUN wget -O /plantuml.jar https://github.com/plantuml/plantuml/releases/download/v1.2022.6/plantuml-1.2022.6.jar
+RUN wget -nv -O /plantuml.jar https://github.com/plantuml/plantuml/releases/download/v1.2022.6/plantuml-1.2022.6.jar
 
 # By default, java writes a 'hsperfdata_<username>' directory in the work dir.
 # This directory is not needed; to ensure it is not written, we set `-XX:-UsePerfData`

test/infrastructure/docker/Dockerfile

@@ -33,7 +33,7 @@ ENV GOPROXY=$goproxy
 # Gets additional CAPD dependencies
 WORKDIR /tmp
 
-RUN curl -LO https://dl.k8s.io/release/v1.25.0/bin/linux/${ARCH}/kubectl && \
+RUN curl -LO "https://dl.k8s.io/release/v1.25.0/bin/linux/${ARCH}/kubectl" && \
     chmod +x ./kubectl && \
     mv ./kubectl /usr/bin/kubectl
 

util/conditions/matcher.go

@@ -42,7 +42,7 @@ func (m matchConditions) Match(actual interface{}) (success bool, err error) {
 		elems = append(elems, MatchCondition(condition))
 	}
 
-	return gomega.ConsistOf(elems).Match(actual)
+	return gomega.ConsistOf(elems...).Match(actual)
 }
 
 func (m matchConditions) FailureMessage(actual interface{}) (message string) {