Skip to content

Commit c587e3e

Browse files
authored
Merge pull request #12598 from sbueringer/pr-export-webhook
🐛 Export ExtensionConfig webhook
2 parents e887a48 + 62a8d2b commit c587e3e

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

internal/test/envtest/environment.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ import (
7272
expapiwebhooks "sigs.k8s.io/cluster-api/exp/webhooks"
7373
"sigs.k8s.io/cluster-api/feature"
7474
internalwebhooks "sigs.k8s.io/cluster-api/internal/webhooks"
75-
runtimewebhooks "sigs.k8s.io/cluster-api/internal/webhooks/runtime"
7675
"sigs.k8s.io/cluster-api/util/kubeconfig"
7776
"sigs.k8s.io/cluster-api/util/test/builder"
7877
"sigs.k8s.io/cluster-api/version"
@@ -390,7 +389,7 @@ func newEnvironment(scheme *runtime.Scheme, additionalCRDDirectoryPaths []string
390389
if err := (&expapiwebhooks.MachinePool{}).SetupWebhookWithManager(mgr); err != nil {
391390
klog.Fatalf("unable to create webhook for machinepool: %+v", err)
392391
}
393-
if err := (&runtimewebhooks.ExtensionConfig{}).SetupWebhookWithManager(mgr); err != nil {
392+
if err := (&webhooks.ExtensionConfig{}).SetupWebhookWithManager(mgr); err != nil {
394393
klog.Fatalf("unable to create webhook for extensionconfig: %+v", err)
395394
}
396395
if err := (&expipamwebhooks.IPAddress{}).SetupWebhookWithManager(mgr); err != nil {

main.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,6 @@ import (
8383
"sigs.k8s.io/cluster-api/internal/contract"
8484
internalruntimeclient "sigs.k8s.io/cluster-api/internal/runtime/client"
8585
runtimeregistry "sigs.k8s.io/cluster-api/internal/runtime/registry"
86-
runtimewebhooks "sigs.k8s.io/cluster-api/internal/webhooks/runtime"
8786
"sigs.k8s.io/cluster-api/util/apiwarnings"
8887
"sigs.k8s.io/cluster-api/util/flags"
8988
"sigs.k8s.io/cluster-api/version"
@@ -833,7 +832,7 @@ func setupWebhooks(ctx context.Context, mgr ctrl.Manager, clusterCacheReader web
833832

834833
// NOTE: ExtensionConfig is behind the RuntimeSDK feature gate flag. The webhook will prevent creating or updating
835834
// new objects if the feature flag is disabled.
836-
if err := (&runtimewebhooks.ExtensionConfig{}).SetupWebhookWithManager(mgr); err != nil {
835+
if err := (&webhooks.ExtensionConfig{}).SetupWebhookWithManager(mgr); err != nil {
837836
setupLog.Error(err, "Unable to create webhook", "webhook", "ExtensionConfig")
838837
os.Exit(1)
839838
}

webhooks/alias.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import (
2525

2626
clusterv1 "sigs.k8s.io/cluster-api/api/core/v1beta2"
2727
"sigs.k8s.io/cluster-api/internal/webhooks"
28+
runtimewebhooks "sigs.k8s.io/cluster-api/internal/webhooks/runtime"
2829
)
2930

3031
// Cluster implements a validating and defaulting webhook for Cluster.
@@ -125,3 +126,11 @@ type ClusterResourceSetBinding struct{}
125126
func (webhook *ClusterResourceSetBinding) SetupWebhookWithManager(mgr ctrl.Manager) error {
126127
return (&webhooks.ClusterResourceSetBinding{}).SetupWebhookWithManager(mgr)
127128
}
129+
130+
// ExtensionConfig implements a defaulting and validating webhook for ExtensionConfig.
131+
type ExtensionConfig struct{}
132+
133+
// SetupWebhookWithManager sets up ClusterResourceSet webhooks.
134+
func (webhook *ExtensionConfig) SetupWebhookWithManager(mgr ctrl.Manager) error {
135+
return (&runtimewebhooks.ExtensionConfig{}).SetupWebhookWithManager(mgr)
136+
}

0 commit comments

Comments
 (0)