Merge pull request #7450 from oscr/enable-revive-unused

✨ Enable revive linter unused-parameter and fix all findings

Author: k8s-ci-robot

.golangci.yml

@@ -176,7 +176,7 @@ linters-settings:
       - name: errorf
       - name: empty-block
       - name: superfluous-else
-      #- name: unused-parameter  # TODO This is a recommended rule with many findings which may require it's own pr.
+      - name: unused-parameter
       - name: unreachable-code
       - name: redefines-builtin-id
       #

api/v1alpha3/conversion.go

@@ -277,13 +277,13 @@ func (dst *MachineHealthCheckList) ConvertFrom(srcRaw conversion.Hub) error {
 	return Convert_v1beta1_MachineHealthCheckList_To_v1alpha3_MachineHealthCheckList(src, dst, nil)
 }
 
-func Convert_v1beta1_MachineSetStatus_To_v1alpha3_MachineSetStatus(in *clusterv1.MachineSetStatus, out *MachineSetStatus, s apiconversion.Scope) error {
+func Convert_v1beta1_MachineSetStatus_To_v1alpha3_MachineSetStatus(in *clusterv1.MachineSetStatus, out *MachineSetStatus, _ apiconversion.Scope) error {
 	// Status.Conditions was introduced in v1alpha4, thus requiring a custom conversion function; the values is going to be preserved in an annotation thus allowing roundtrip without loosing informations
 	return autoConvert_v1beta1_MachineSetStatus_To_v1alpha3_MachineSetStatus(in, out, nil)
 }
 
 func Convert_v1beta1_ClusterSpec_To_v1alpha3_ClusterSpec(in *clusterv1.ClusterSpec, out *ClusterSpec, s apiconversion.Scope) error {
-	// NOTE: custom conversion func is required because spec.Topology does not exists in v1alpha3
+	// NOTE: custom conversion func is required because spec.Topology does not exist in v1alpha3
 	return autoConvert_v1beta1_ClusterSpec_To_v1alpha3_ClusterSpec(in, out, s)
 }
 

bootstrap/kubeadm/api/v1alpha3/conversion_test.go

@@ -82,12 +82,12 @@ func clusterConfigurationFuzzer(obj *upstreamv1beta1.ClusterConfiguration, c fuz
 	obj.UseHyperKubeImage = false
 }
 
-func kubeadmBootstrapTokenStringFuzzerV1UpstreamBeta1(in *upstreamv1beta1.BootstrapTokenString, c fuzz.Continue) {
+func kubeadmBootstrapTokenStringFuzzerV1UpstreamBeta1(in *upstreamv1beta1.BootstrapTokenString, _ fuzz.Continue) {
 	in.ID = "abcdef"
 	in.Secret = "abcdef0123456789"
 }
 
-func kubeadmBootstrapTokenStringFuzzerV1Beta1(in *bootstrapv1.BootstrapTokenString, c fuzz.Continue) {
+func kubeadmBootstrapTokenStringFuzzerV1Beta1(in *bootstrapv1.BootstrapTokenString, _ fuzz.Continue) {
 	in.ID = "abcdef"
 	in.Secret = "abcdef0123456789"
 }

bootstrap/kubeadm/api/v1alpha4/conversion_test.go

@@ -80,17 +80,17 @@ func clusterConfigurationFuzzer(obj *upstreamv1beta1.ClusterConfiguration, c fuz
 	obj.UseHyperKubeImage = false
 }
 
-func kubeadmBootstrapTokenStringFuzzerV1UpstreamBeta1(in *upstreamv1beta1.BootstrapTokenString, c fuzz.Continue) {
+func kubeadmBootstrapTokenStringFuzzerV1UpstreamBeta1(in *upstreamv1beta1.BootstrapTokenString, _ fuzz.Continue) {
 	in.ID = fakeID
 	in.Secret = fakeSecret
 }
 
-func kubeadmBootstrapTokenStringFuzzerV1Beta1(in *bootstrapv1.BootstrapTokenString, c fuzz.Continue) {
+func kubeadmBootstrapTokenStringFuzzerV1Beta1(in *bootstrapv1.BootstrapTokenString, _ fuzz.Continue) {
 	in.ID = fakeID
 	in.Secret = fakeSecret
 }
 
-func kubeadmBootstrapTokenStringFuzzerV1Alpha4(in *BootstrapTokenString, c fuzz.Continue) {
+func kubeadmBootstrapTokenStringFuzzerV1Alpha4(in *BootstrapTokenString, _ fuzz.Continue) {
 	in.ID = fakeID
 	in.Secret = fakeSecret
 }

bootstrap/kubeadm/api/v1beta1/kubeadmconfig_webhook.go

@@ -70,7 +70,7 @@ func (c *KubeadmConfig) ValidateCreate() error {
 }
 
 // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type.
-func (c *KubeadmConfig) ValidateUpdate(old runtime.Object) error {
+func (c *KubeadmConfig) ValidateUpdate(_ runtime.Object) error {
 	return c.Spec.validate(c.Name)
 }
 

bootstrap/kubeadm/api/v1beta1/kubeadmconfigtemplate_webhook.go

@@ -49,7 +49,7 @@ func (r *KubeadmConfigTemplate) ValidateCreate() error {
 }
 
 // ValidateUpdate implements webhook.Validator so a webhook will be registered for the type.
-func (r *KubeadmConfigTemplate) ValidateUpdate(old runtime.Object) error {
+func (r *KubeadmConfigTemplate) ValidateUpdate(_ runtime.Object) error {
 	return r.Spec.validate(r.Name)
 }
 

cmd/clusterctl/client/client_test.go

@@ -38,7 +38,7 @@ import (
 )
 
 // TestNewFakeClient is a fake test to document fakeClient usage.
-func TestNewFakeClient(t *testing.T) {
+func TestNewFakeClient(_ *testing.T) {
 	// create a fake config with a provider named P1 and a variable named var
 	repository1Config := config.NewProvider("p1", "url", clusterctlv1.CoreProviderType)
 

cmd/clusterctl/client/cluster/internal/dryrun/client.go

@@ -248,7 +248,7 @@ func (c *Client) Delete(ctx context.Context, obj client.Object, opts ...client.D
 
 // Update updates the given obj in the internal object tracker.
 // NOTE: Topology reconciler does not use update, so we are skipping implementation for now.
-func (c *Client) Update(ctx context.Context, obj client.Object, opts ...client.UpdateOption) error {
+func (c *Client) Update(_ context.Context, _ client.Object, _ ...client.UpdateOption) error {
 	panic("Update method is not supported by the dryrun client")
 }
 
@@ -284,7 +284,7 @@ func (c *Client) Patch(ctx context.Context, obj client.Object, patch client.Patc
 
 // DeleteAllOf deletes all objects of the given type matching the given options.
 // NOTE: Topology reconciler does not use DeleteAllOf, so we are skipping implementation for now.
-func (c *Client) DeleteAllOf(ctx context.Context, obj client.Object, opts ...client.DeleteAllOfOption) error {
+func (c *Client) DeleteAllOf(_ context.Context, _ client.Object, _ ...client.DeleteAllOfOption) error {
 	panic("DeleteAllOf method is not supported by the dryrun client")
 }
 

cmd/clusterctl/client/cluster/inventory_test.go

@@ -31,7 +31,7 @@ import (
 	"sigs.k8s.io/cluster-api/cmd/clusterctl/internal/test"
 )
 
-func fakePollImmediateWaiter(interval, timeout time.Duration, condition wait.ConditionFunc) error {
+func fakePollImmediateWaiter(_, _ time.Duration, _ wait.ConditionFunc) error {
 	return nil
 }
 

cmd/clusterctl/client/cluster/topology.go

@@ -631,9 +631,9 @@ func filterObjects(objs []*unstructured.Unstructured, gvks ...schema.GroupVersio
 
 type noOpRecorder struct{}
 
-func (nr *noOpRecorder) Event(_ runtime.Object, _, _, _ string)                       {}
-func (nr *noOpRecorder) Eventf(_ runtime.Object, _, _, _ string, args ...interface{}) {}
-func (nr *noOpRecorder) AnnotatedEventf(_ runtime.Object, _ map[string]string, _, _, _ string, args ...interface{}) {
+func (nr *noOpRecorder) Event(_ runtime.Object, _, _, _ string)                    {}
+func (nr *noOpRecorder) Eventf(_ runtime.Object, _, _, _ string, _ ...interface{}) {}
+func (nr *noOpRecorder) AnnotatedEventf(_ runtime.Object, _ map[string]string, _, _, _ string, _ ...interface{}) {
 }
 
 func objToRef(o *unstructured.Unstructured) *corev1.ObjectReference {