Merge pull request #7668 from killianmuldoon/fix-flaky-md-test

k8s-ci-robot · web-flow · commit d294bfbc5ef5 · 2022-12-12T04:39:34.000-08:00
🐛 Fix flakiness in MD controller test
diff --git a/internal/controllers/machinedeployment/machinedeployment_controller_test.go b/internal/controllers/machinedeployment/machinedeployment_controller_test.go
@@ -404,7 +404,7 @@ func TestMachineDeploymentReconciler(t *testing.T) {
 			}
 
 			return len(machineSets.Items)
-		}, timeout*5).Should(BeEquivalentTo(0))
+		}, timeout*10).Should(BeEquivalentTo(0))
 
 		t.Log("Verifying MachineDeployment has correct Conditions")
 		g.Eventually(func() bool {

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ func TestMachineDeploymentReconciler(t *testing.T) {`
`404`	`404`	`}`
`405`	`405`
`406`	`406`	`return len(machineSets.Items)`
`407`		`- }, timeout*5).Should(BeEquivalentTo(0))`
	`407`	`+ }, timeout*10).Should(BeEquivalentTo(0))`
`408`	`408`
`409`	`409`	`t.Log("Verifying MachineDeployment has correct Conditions")`
`410`	`410`	`g.Eventually(func() bool {`