Skip to content

Commit da6769b

Browse files
Fix v1alpha4 references in clusterctl comments
1 parent c680942 commit da6769b

File tree

6 files changed

+12
-16
lines changed

6 files changed

+12
-16
lines changed

cmd/clusterctl/api/v1alpha3/provider_type.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ type Provider struct {
5050
// WatchedNamespace indicates the namespace where the provider controller is watching.
5151
// If empty the provider controller is watching for objects in all namespaces.
5252
//
53-
// Deprecated: in clusterctl v1alpha4 all the providers watch all the namespaces; this field will be removed in a future version of this API
53+
// Deprecated: providers complying with the Cluster API v1alpha4 contract or above must watch all namespaces; this field will be removed in a future version of this API
5454
// +optional
5555
WatchedNamespace string `json:"watchedNamespace,omitempty"`
5656
}

cmd/clusterctl/client/client.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,9 +54,7 @@ type Client interface {
5454
// Move moves all the Cluster API objects existing in a namespace (or from all the namespaces if empty) to a target management cluster.
5555
Move(options MoveOptions) error
5656

57-
// PlanUpgrade returns a set of suggested Upgrade plans for the cluster, and more specifically:
58-
// - Upgrade to the latest version in the v1alpha3 series: ....
59-
// - Upgrade to the latest version in the v1alpha4 series: ....
57+
// PlanUpgrade returns a set of suggested Upgrade plans for the cluster.
6058
PlanUpgrade(options PlanUpgradeOptions) ([]UpgradePlan, error)
6159

6260
// PlanCertManagerUpgrade returns a CertManagerUpgradePlan.

cmd/clusterctl/client/cluster/upgrader.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,7 @@ import (
3838

3939
// ProviderUpgrader defines methods for supporting provider upgrade.
4040
type ProviderUpgrader interface {
41-
// Plan returns a set of suggested Upgrade plans for the management cluster, and more specifically:
42-
// - Upgrade to the latest version in the v1alpha3 series: ....
43-
// - Upgrade to the latest version in the v1alpha4 series: ....
41+
// Plan returns a set of suggested Upgrade plans for the management cluster.
4442
Plan() ([]UpgradePlan, error)
4543

4644
// ApplyPlan executes an upgrade following an UpgradePlan generated by clusterctl.
@@ -109,7 +107,7 @@ func (u *providerUpgrader) Plan() ([]UpgradePlan, error) {
109107
// all the providers can upgrade to the latest release supporting v1alpha5 (not supported in current clusterctl release,
110108
// but upgrade plan should report these options)
111109
// Please note that upgrade plan also works on management cluster still in v1alpha3. In this case upgrade plan is shown, but
112-
// upgrade to latest version in the v1alpha3 series are not supported using clusterctl v1alpha4 (use older releases).
110+
// upgrade to latest version in the v1alpha3 series are not supported using clusterctl v1alpha4 or v1beta1 (use older releases).
113111

114112
// Gets the upgrade info for the core provider.
115113
coreProviders := providerList.FilterCore()

cmd/clusterctl/client/init.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func (c *clusterctlClient) Init(options InitOptions) ([]Components, error) {
100100
return nil, err
101101
}
102102

103-
// Ensure this command only runs against v1alpha4 management clusters
103+
// Ensure this command only runs against v1beta1 management clusters
104104
if err := clusterClient.ProviderInventory().CheckCAPIContract(cluster.AllowCAPINotInstalled{}); err != nil {
105105
return nil, err
106106
}
@@ -172,7 +172,7 @@ func (c *clusterctlClient) InitImages(options InitOptions) ([]string, error) {
172172
return nil, err
173173
}
174174

175-
// Ensure this command only runs against empty management clusters or v1alpha4 management clusters.
175+
// Ensure this command only runs against empty management clusters or v1beta1 management clusters.
176176
if err := clusterClient.ProviderInventory().CheckCAPIContract(cluster.AllowCAPINotInstalled{}); err != nil {
177177
return nil, err
178178
}

cmd/clusterctl/config/crd/bases/clusterctl.cluster.x-k8s.io_providers.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cmd/clusterctl/config/manifest/clusterctl-api.yaml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)