Merge pull request #10855 from sbueringer/pr-deprecate-md-revision-mgmt

🌱 Deprecate MachineDeployment revision management

Author: k8s-ci-robot

.golangci.yml

@@ -235,7 +235,11 @@ issues:
   - linters:
       - staticcheck
     text: "SA1019: (bootstrapv1.ClusterStatus|KubeadmConfigSpec.UseExperimentalRetryJoin|scope.Config.Spec.UseExperimentalRetryJoin|DockerMachine.Spec.Bootstrapped|machineStatus.Bootstrapped|c.TopologyPlan|clusterv1.ClusterClassVariableMetadata|(variable|currentDefinition|specVar|newVariableDefinition|statusVarDefinition).Metadata) is deprecated"
-  # Deprecations for MHC MaxUnhealthy, UnhealthyRange
+  # Deprecations for MD revision management
+  - linters:
+      - staticcheck
+    text: "SA1019: (deployment|m|md)(.Spec.RevisionHistoryLimit)|clusterv1.RevisionHistoryAnnotation|c.RolloutUndo is deprecated"
+    # Deprecations for MHC MaxUnhealthy, UnhealthyRange
   - linters:
       - staticcheck
     text: "SA1019: (mhc|m)(.Spec.MaxUnhealthy|.Spec.UnhealthyRange) is deprecated"

api/v1beta1/machinedeployment_types.go

@@ -42,6 +42,8 @@ const (
 	RevisionAnnotation = "machinedeployment.clusters.x-k8s.io/revision"
 
 	// RevisionHistoryAnnotation maintains the history of all old revisions that a machine set has served for a machine deployment.
+	//
+	// Deprecated: This annotation is deprecated and is going to be removed in the next apiVersion. Please see https://github.com/kubernetes-sigs/cluster-api/issues/10479 for more details.
 	RevisionHistoryAnnotation = "machinedeployment.clusters.x-k8s.io/revision-history"
 
 	// DesiredReplicasAnnotation is the desired replicas for a machine deployment recorded as an annotation
@@ -129,6 +131,9 @@ type MachineDeploymentSpec struct {
 	// The number of old MachineSets to retain to allow rollback.
 	// This is a pointer to distinguish between explicit zero and not specified.
 	// Defaults to 1.
+	//
+	// Deprecated: This field is deprecated and is going to be removed in the next apiVersion. Please see https://github.com/kubernetes-sigs/cluster-api/issues/10479 for more details.
+	//
 	// +optional
 	RevisionHistoryLimit *int32 `json:"revisionHistoryLimit,omitempty"`
 

api/v1beta1/zz_generated.openapi.go

@@ -85,6 +85,8 @@ type AlphaClient interface {
 	// RolloutResume provides rollout resume of paused cluster-api resources
 	RolloutResume(ctx context.Context, options RolloutResumeOptions) error
 	// RolloutUndo provides rollout rollback of cluster-api resources
+	//
+	// Deprecated: RolloutUndo is deprecated and will be removed in one of the upcoming releases.
 	RolloutUndo(ctx context.Context, options RolloutUndoOptions) error
 	// TopologyPlan dry runs the topology reconciler
 	//

cmd/clusterctl/client/client.go

@@ -67,6 +67,8 @@ func NewCmdRolloutUndo(cfgFile string) *cobra.Command {
 	cmd.Flags().StringVarP(&undoOpt.namespace, "namespace", "n", "", "Namespace where the resource(s) reside. If unspecified, the defult namespace will be used.")
 	cmd.Flags().Int64Var(&undoOpt.toRevision, "to-revision", undoOpt.toRevision, "The revision to rollback to. Default to 0 (last revision).")
 
+	cmd.Deprecated = "it will be removed in one of the upcoming releases.\n"
+
 	return cmd
 }