Skip to content

Commit eb808f2

Browse files
authored
Merge pull request #8035 from ykakarap/clusterct-rollback-valid-resources
🌱 remove KCP as a valid resource type for rollback
2 parents aa5eacf + 1e2d604 commit eb808f2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

cmd/clusterctl/client/alpha/rollout.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@ var validResourceTypes = []string{
3434
KubeadmControlPlane,
3535
}
3636

37+
var validRollbackResourceTypes = []string{
38+
MachineDeployment,
39+
}
40+
3741
// Rollout defines the behavior of a rollout implementation.
3842
type Rollout interface {
3943
ObjectRestarter(cluster.Proxy, corev1.ObjectReference) error

cmd/clusterctl/client/alpha/rollout_rollbacker.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ func (r *rollout) ObjectRollbacker(proxy cluster.Proxy, ref corev1.ObjectReferen
4141
return err
4242
}
4343
default:
44-
return errors.Errorf("invalid resource type %q, valid values are %v", ref.Kind, validResourceTypes)
44+
return errors.Errorf("invalid resource type %q, valid values are %v", ref.Kind, validRollbackResourceTypes)
4545
}
4646
return nil
4747
}

0 commit comments

Comments
 (0)