Skip to content

Commit ef3c5c4

Browse files
authored
Merge pull request #8593 from joekr/update-release-docs
📖 updates to release task docs and notes tool
2 parents f42b723 + 78b66ba commit ef3c5c4

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

docs/release/release-tasks.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,9 @@ to a newer Go minor version according to our [backport policy](./../../CONTRIBUT
188188
1. Ensure CI is stable before cutting the release (e.g. by checking with the CI manager)
189189
Note: special attention should be given to image scan results, so we can avoid cutting a release with CVE or document known CVEs in release notes.
190190
2. Create and push the release tags to the GitHub repository:
191+
192+
**NOTE:** clusterctl will have issues installing providers between the time the release tag is cut and the Github release is published. See [issue 7889](https://github.com/kubernetes-sigs/cluster-api/issues/7889) for more details
193+
191194
```bash
192195
# Export the tag of the release to be cut, e.g.:
193196
export RELEASE_TAG=v1.0.1
@@ -216,12 +219,13 @@ to a newer Go minor version according to our [backport policy](./../../CONTRIBUT
216219
git to use `https` instead via `git config --global url."https://github.com/".insteadOf [email protected]:`.
217220
* This will automatically create a PR in [k8s.io](https://github.com/kubernetes/k8s.io) and assign the CAPI maintainers.
218221
4. Merge the PR (/lgtm + /hold cancel) and verify the images are available in the production registry:
219-
```bash
220-
docker pull registry.k8s.io/cluster-api/clusterctl:${RELEASE_TAG}
221-
docker pull registry.k8s.io/cluster-api/cluster-api-controller:${RELEASE_TAG}
222-
docker pull registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:${RELEASE_TAG}
223-
docker pull registry.k8s.io/cluster-api/kubeadm-control-plane-controller:${RELEASE_TAG}
224-
```
222+
* Wait for the [promotion prow job](https://prow.k8s.io/?repo=kubernetes%2Fk8s.io&job=post-k8sio-image-promo) to complete successfully. Then test the production images are accessible:
223+
```bash
224+
docker pull registry.k8s.io/cluster-api/clusterctl:${RELEASE_TAG}
225+
docker pull registry.k8s.io/cluster-api/cluster-api-controller:${RELEASE_TAG}
226+
docker pull registry.k8s.io/cluster-api/kubeadm-bootstrap-controller:${RELEASE_TAG}
227+
docker pull registry.k8s.io/cluster-api/kubeadm-control-plane-controller:${RELEASE_TAG}
228+
```
225229
4. Publish the release in GitHub:
226230
1. Get the final release notes from the docs team and add them to the GitHub release.
227231
2. Publish the release (ensure to flag the release as pre-release if necessary).

hack/tools/release/notes.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ func run() int {
204204
// TODO Turn this into a link (requires knowing the project name + organization)
205205
fmt.Printf("Changes since %v\n---\n", commitRange)
206206

207-
fmt.Printf("## :chart_with_upwards_trend: Fun stats\n")
207+
fmt.Printf("## :chart_with_upwards_trend: Overview\n")
208208
fmt.Printf("- %d new commits merged\n", len(commits))
209209
fmt.Printf("- %d breaking changes :warning:\n", len(merges[warning]))
210210
fmt.Printf("- %d feature additions ✨\n", len(merges[features]))

0 commit comments

Comments
 (0)