Skip to content

Commit f7a0f24

Browse files
committed
order replica columns in a consistent order
Signed-off-by: Stefan Büringer [email protected]
1 parent 76bb104 commit f7a0f24

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

api/v1beta1/machineset_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,8 +204,8 @@ func (m *MachineSet) Validate() field.ErrorList {
204204
// +kubebuilder:subresource:status
205205
// +kubebuilder:subresource:scale:specpath=.spec.replicas,statuspath=.status.replicas,selectorpath=.status.selector
206206
// +kubebuilder:printcolumn:name="Cluster",type="string",JSONPath=".spec.clusterName",description="Cluster"
207-
// +kubebuilder:printcolumn:name="Replicas",type="integer",JSONPath=".status.replicas",description="Total number of non-terminated machines targeted by this machineset"
208207
// +kubebuilder:printcolumn:name="Desired",type=integer,JSONPath=".spec.replicas",description="Total number of machines desired by this machineset",priority=10
208+
// +kubebuilder:printcolumn:name="Replicas",type="integer",JSONPath=".status.replicas",description="Total number of non-terminated machines targeted by this machineset"
209209
// +kubebuilder:printcolumn:name="Ready",type="integer",JSONPath=".status.readyReplicas",description="Total number of ready machines targeted by this machineset."
210210
// +kubebuilder:printcolumn:name="Available",type="integer",JSONPath=".status.availableReplicas",description="Total number of available machines (ready for at least minReadySeconds)"
211211
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Time duration since creation of MachineSet"

config/crd/bases/cluster.x-k8s.io_machinepools.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -969,15 +969,15 @@ spec:
969969
jsonPath: .spec.clusterName
970970
name: Cluster
971971
type: string
972-
- description: MachinePool replicas count
973-
jsonPath: .status.replicas
974-
name: Replicas
975-
type: string
976972
- description: Total number of machines desired by this MachinePool
977973
jsonPath: .spec.replicas
978974
name: Desired
979975
priority: 10
980976
type: integer
977+
- description: MachinePool replicas count
978+
jsonPath: .status.replicas
979+
name: Replicas
980+
type: string
981981
- description: MachinePool status such as Terminating/Pending/Provisioning/Running/Failed
982982
etc
983983
jsonPath: .status.phase

config/crd/bases/cluster.x-k8s.io_machinesets.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -846,15 +846,15 @@ spec:
846846
jsonPath: .spec.clusterName
847847
name: Cluster
848848
type: string
849-
- description: Total number of non-terminated machines targeted by this machineset
850-
jsonPath: .status.replicas
851-
name: Replicas
852-
type: integer
853849
- description: Total number of machines desired by this machineset
854850
jsonPath: .spec.replicas
855851
name: Desired
856852
priority: 10
857853
type: integer
854+
- description: Total number of non-terminated machines targeted by this machineset
855+
jsonPath: .status.replicas
856+
name: Replicas
857+
type: integer
858858
- description: Total number of ready machines targeted by this machineset.
859859
jsonPath: .status.readyReplicas
860860
name: Ready

exp/api/v1beta1/machinepool_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ func (m *MachinePoolStatus) GetTypedPhase() MachinePoolPhase {
206206
// +kubebuilder:subresource:scale:specpath=.spec.replicas,statuspath=.status.replicas
207207
// +kubebuilder:storageversion
208208
// +kubebuilder:printcolumn:name="Cluster",type="string",JSONPath=".spec.clusterName",description="Cluster"
209-
// +kubebuilder:printcolumn:name="Replicas",type="string",JSONPath=".status.replicas",description="MachinePool replicas count"
210209
// +kubebuilder:printcolumn:name="Desired",type=integer,JSONPath=".spec.replicas",description="Total number of machines desired by this MachinePool",priority=10
210+
// +kubebuilder:printcolumn:name="Replicas",type="string",JSONPath=".status.replicas",description="MachinePool replicas count"
211211
// +kubebuilder:printcolumn:name="Phase",type="string",JSONPath=".status.phase",description="MachinePool status such as Terminating/Pending/Provisioning/Running/Failed etc"
212212
// +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Time duration since creation of MachinePool"
213213
// +kubebuilder:printcolumn:name="Version",type="string",JSONPath=".spec.template.spec.version",description="Kubernetes version associated with this MachinePool"

0 commit comments

Comments
 (0)