Skip to content

Conversation

@nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jul 11, 2024

What this PR does / why we need it:

This change updates the Azure parts of the quick start guide to account for the default auth mechanism in templates changing to Workload Identity in CAPZ v1.16 (coming next week). These changes add steps to change back to Service Principal auth to avoid turning this doc into yet-another-Workload-Identity-setup doc and to continue to support CAPZ v1.15.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes-sigs/cluster-api-provider-azure#4921

/area documentation
/area provider/azure

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation area/provider/azure Issues or PRs related to azure provider labels Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2024
@nojnhuh nojnhuh force-pushed the azure-quickstart branch from 7acdbac to 57f3501 Compare July 11, 2024 19:01
@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 11, 2024

We'd also like to have this in the latest release branch so it's live when we release CAPZ v1.16 next week. No need to wait until before then to merge though.

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

We'd also like to have this in the latest release branch so it's live when we release CAPZ v1.16 next week. No need to wait until before then to merge though.

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nojnhuh
Copy link
Contributor Author

nojnhuh commented Jul 11, 2024

/assign @jackfrancis

Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf0f1316704c63a4881365d490ca3d7d45a8941

@sbueringer
Copy link
Member

Nice, thx!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 3fc347d into kubernetes-sigs:main Jul 12, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 12, 2024
@k8s-infra-cherrypick-robot

@nojnhuh: new pull request created: #10859

In response to this:

We'd also like to have this in the latest release branch so it's live when we release CAPZ v1.16 next week. No need to wait until before then to merge though.

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CAPI quick start for CAPZ 1.16

5 participants