🌱Use inCluster kubeconfig if empty var provided #11865
Conversation
k8s-ci-robot
added
area/testing
k8s-ci-robot
added
the
size/S
m-messiah
force-pushed
the
allow-to-use-in-cluster-kubeconfig
branch
from
5ff9e33 to
d8b6f51
Compare
|
/test pull-cluster-api-e2e-blocking-main |
|
/test pull-cluster-api-e2e-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 439ad1d61b4c83b248895e91c1644cf43378221c
|
vincepri
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This was apparently a breaking change for CAPZ tests: see kubernetes-sigs/cluster-api-provider-azure#5530 and kubernetes-sigs/cluster-api-provider-azure#5533. I'd appreciate some advice on how to work around this change. |
|
How did this break your test? I.e. in which case & how is it failing because of this change? |
|
Apparently CAPZ was relying on the default behavior of I think I've worked around it when updating to v1.9.6 by adding this line to our test setup before we create bootstrap clusters: kubeconfigPath = clientcmd.NewDefaultClientConfigLoadingRules().GetDefaultFilename() |
|
Ah, I see. That is a good point |
5 participants
What this PR does / why we need it:
The current cluster_proxy behaves differently from what is expected for empty kubeconfig variables in kubectl load rules.
The behaviour forbids the usage of cluster proxy inside the pod in the cluster.
This checks the possibility of in-cluster configuration and keeps the same behaviour, which is not found.
/area testing