Skip to content

⚠️ feat(clusterctl): block move when Cluster or ClusterClass is paused #12786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚠️ feat(clusterctl): block move when Cluster or ClusterClass is paused #12786

wants to merge 1 commit into from
+167 −10

Conversation

alexandrevilain
Copy link

What this PR does / why we need it: Add checks that ensure clusters and cluster classes are not paused before starting move operations. This ensures that the paused state is not inadvertently altered during the directory move operation.

Marked this PR as a breaking change as it may break some users worflows.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #12742

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 19, 2025
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @alexandrevilain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alexandrevilain alexandrevilain mentioned this pull request Sep 19, 2025
Closed
sivchari
sivchari reviewed Oct 7, 2025
View reviewed changes
Copy link
Member

@sivchari sivchari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits.

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 7, 2025
@alexandrevilain alexandrevilain force-pushed the feat/clusterctl-block-move-if-cluster-paused branch from ffcd0e0 to b442fcf Compare October 7, 2025 08:36
@alexandrevilain
feat(clusterctl): block move when Cluster or ClusterClass is paused
a7f54f8 
Add checks that ensure clusters and cluster classes are not paused before starting move operations.

Signed-off-by: alexandre.vilain <[email protected]>
@alexandrevilain alexandrevilain force-pushed the feat/clusterctl-block-move-if-cluster-paused branch from b442fcf to a7f54f8 Compare October 7, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

1 more reviewer

@sivchari sivchari sivchari left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clusterctl move --to-directory should preserve the original Cluster’s spec.pause value
4 participants
@alexandrevilain @k8s-ci-robot @sbueringer @sivchari