Skip to content

Commit d662406

Browse files
authored
Merge pull request #100 from BlaineEXE/fix-kustomize-install
Update kustomize deployment and readme
2 parents f1ff798 + 1cc5c46 commit d662406

File tree

6 files changed

+52
-91
lines changed

6 files changed

+52
-91
lines changed

README.md

Lines changed: 14 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,32 @@
11
![version](https://img.shields.io/badge/status-pre--alpha-lightgrey) ![apiVersion](https://img.shields.io/badge/apiVersion-v1alpha1-lightgreen)
22

33

4-
# Container Object Storage Interface API
4+
# Container Object Storage Interface
55

6-
This repository hosts the API defintion of the Custom Resource Definitions (CRD) used for the Container Object Storage Interface (COSI) project. The provisioned unit of storage is a `Bucket`. The following CRDs are defined for managing the lifecycle of Buckets:
6+
This repository hosts the Container Object Storage Interface (COSI) project.
77

8-
- BucketClaim - Represents a request to provision a Bucket
9-
- BucketClass - Represents a class of Buckets with similar characteristics
10-
- Bucket - Represents a Bucket or its equivalent in the storage backend
8+
## Documentation
119

12-
The following CRDs are defined for managing the lifecycle of workloads accessing the Bucket:
10+
To deploy, run `kubectl apply -k .`
1311

14-
- BucketAccessClass - Represents a class of accessors with similar access requirements
15-
- BucketAccess - Represents a access token or service account in the storage backend
16-
17-
**NOTE**: All of the APIs are defined under the API group `objectstorage.k8s.io`.
18-
19-
For more information about COSI, visit our [documentation](https://container-object-storage-interface.github.io/docs).
2012
## Developer Guide
2113

22-
All API definitions are in [`apis/objectstorage.k8s.io/`](./apis/objectstorage/). All API changes **_MUST_** satisfy the following requirements:
14+
All API definitions are in [`client/apis/objectstorage`](./client/apis/objectstorage/). All API changes **_MUST_** satisfy the following requirements:
2315

24-
- Must be backwards compatible
25-
- Must be in-sync with the API definitions in [sigs.k8s.io/container-object-storage-interface-spec](https://sigs.k8s.io/container-object-storage-interface-spec)
16+
- Must be backwards compatible
17+
- Must be in-sync with the API definitions in [sigs.k8s.io/container-object-storage-interface-spec](https://sigs.k8s.io/container-object-storage-interface-spec)
2618

2719
### Build and Test
2820

29-
1. Test and Build the project
30-
31-
```
32-
make all
33-
```
34-
35-
2. Generate CRDs
36-
37-
```
38-
make codegen
39-
```
21+
See `make help` for assistance
4022

4123
## Adding new fields to protocols
4224

43-
1. Create a new issue raising a RFC for the changes following this format:
25+
Create a new issue raising a RFC for the changes following this format:
26+
27+
**Title:** [RFC] Changes to protocol xyz
4428

45-
Title: [RFC] Changes to protocol xyz
46-
> **Info**:
29+
**Description:**
4730
> 1. Protocol:
4831
> 2. Fields Added:
4932
> 3. Why is this change neccessary?
@@ -54,10 +37,8 @@ Title: [RFC] Changes to protocol xyz
5437
5538
## References
5639

57-
- [Documentation](https://container-object-storage-interface.github.io/)
58-
- [Deployment Guide](https://container-object-storage-interface.github.io/docs/deployment-guide)
59-
- [Weekly Meetings](https://container-object-storage-interface.github.io/docs/community/weekly-meetings)
60-
- [Roadmap](https://github.com/orgs/kubernetes-sigs/projects/8)
40+
- Weekly Meetings: Thursdays from 13:30 to 14:00 US Eastern Time
41+
- [Roadmap](https://github.com/orgs/kubernetes-sigs/projects/63/)
6142

6243
## Community, discussion, contribution, and support
6344

controller/kustomization.yaml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,13 @@
22
apiVersion: kustomize.config.k8s.io/v1beta1
33
kind: Kustomization
44

5-
commonLabels:
6-
app.kubernetes.io/part-of: container-object-storage-interface
7-
app.kubernetes.io/component: controller
8-
app.kubernetes.io/version: main
9-
app.kubernetes.io/name: container-object-storage-interface-controller
5+
labels:
6+
- includeTemplates: true
7+
pairs:
8+
app.kubernetes.io/component: controller
9+
app.kubernetes.io/name: container-object-storage-interface-controller
10+
app.kubernetes.io/part-of: container-object-storage-interface
11+
app.kubernetes.io/managed-by: kustomize
1012

1113
resources:
1214
- resources/sa.yaml

controller/resources/deployment.yaml

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,7 @@ apiVersion: apps/v1
44
metadata:
55
name: objectstorage-controller
66
labels:
7-
app.kubernetes.io/part-of: container-object-storage-interface
8-
app.kubernetes.io/component: controller
9-
app.kubernetes.io/version: main
10-
app.kubernetes.io/name: container-object-storage-interface-controller
7+
app: container-object-storage-interface-controller
118
spec:
129
replicas: 1
1310
strategy:
@@ -16,22 +13,15 @@ spec:
1613
maxSurge: 1
1714
selector:
1815
matchLabels:
19-
app.kubernetes.io/part-of: container-object-storage-interface
20-
app.kubernetes.io/component: controller
21-
app.kubernetes.io/version: main
22-
app.kubernetes.io/name: container-object-storage-interface-controller
16+
app: container-object-storage-interface-controller
2317
template:
2418
metadata:
2519
labels:
26-
app.kubernetes.io/part-of: container-object-storage-interface
27-
app.kubernetes.io/component: controller
28-
app.kubernetes.io/version: main
29-
app.kubernetes.io/name: container-object-storage-interface-controller
20+
app: container-object-storage-interface-controller
3021
spec:
3122
serviceAccountName: objectstorage-controller-sa
3223
containers:
3324
- name: objectstorage-controller
3425
image: gcr.io/k8s-staging-sig-storage/objectstorage-controller:v20221027-v0.1.1-8-g300019f
35-
imagePullPolicy: Always
3626
args:
37-
- "--v=5"
27+
- "--v=5"

controller/resources/rbac.yaml

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,28 +4,22 @@ apiVersion: rbac.authorization.k8s.io/v1
44
metadata:
55
name: objectstorage-controller-role
66
namespace: default
7-
labels:
8-
app.kubernetes.io/part-of: container-object-storage-interface
9-
app.kubernetes.io/component: controller
10-
app.kubernetes.io/version: main
11-
app.kubernetes.io/name: container-object-storage-interface-controller
127
rules:
13-
- apiGroups: ["objectstorage.k8s.io"]
14-
resources: ["bucketclaims", "bucketaccesses", "bucketclaims/status", "bucketaccesses/status"]
15-
verbs: ["get", "list", "watch", "update"]
16-
- apiGroups: ["objectstorage.k8s.io"]
17-
resources: ["buckets"]
18-
verbs: ["get", "list", "watch", "update", "create", "delete"]
19-
- apiGroups: ["objectstorage.k8s.io"]
20-
resources: ["bucketclasses","bucketaccessclasses"]
21-
verbs: ["get", "list"]
22-
- apiGroups: [""]
23-
resources: ["events"]
24-
verbs: ["list", "watch", "create", "update", "patch"]
25-
- apiGroups: [""]
26-
resources: ["configmaps", "serviceaccounts"]
27-
verbs: ["list", "get"]
28-
8+
- apiGroups: ["objectstorage.k8s.io"]
9+
resources: ["bucketclaims", "bucketaccesses", "bucketclaims/status", "bucketaccesses/status"]
10+
verbs: ["get", "list", "watch", "update"]
11+
- apiGroups: ["objectstorage.k8s.io"]
12+
resources: ["buckets"]
13+
verbs: ["get", "list", "watch", "update", "create", "delete"]
14+
- apiGroups: ["objectstorage.k8s.io"]
15+
resources: ["bucketclasses","bucketaccessclasses"]
16+
verbs: ["get", "list"]
17+
- apiGroups: [""]
18+
resources: ["events"]
19+
verbs: ["list", "watch", "create", "update", "patch"]
20+
- apiGroups: [""]
21+
resources: ["configmaps", "serviceaccounts"]
22+
verbs: ["list", "get"]
2923
---
3024
kind: ClusterRoleBinding
3125
apiVersion: rbac.authorization.k8s.io/v1
@@ -57,9 +51,9 @@ metadata:
5751
app.kubernetes.io/version: main
5852
app.kubernetes.io/name: container-object-storage-interface-controller
5953
rules:
60-
- apiGroups: ["coordination.k8s.io"]
61-
resources: ["leases"]
62-
verbs: ["get", "watch", "list", "delete", "update", "create"]
54+
- apiGroups: ["coordination.k8s.io"]
55+
resources: ["leases"]
56+
verbs: ["get", "watch", "list", "delete", "update", "create"]
6357
---
6458
kind: RoleBinding
6559
apiVersion: rbac.authorization.k8s.io/v1

controller/resources/sa.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,3 @@ apiVersion: v1
33
kind: ServiceAccount
44
metadata:
55
name: objectstorage-controller-sa
6-
labels:
7-
app.kubernetes.io/part-of: container-object-storage-interface
8-
app.kubernetes.io/component: controller
9-
app.kubernetes.io/version: main
10-
app.kubernetes.io/name: container-object-storage-interface-controller

kustomization.yaml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,15 @@ apiVersion: kustomize.config.k8s.io/v1beta1
33
kind: Kustomization
44

55
commonAnnotations:
6-
cosi.storage.k8s.io/authors: "Kubernetes Authors"
7-
cosi.storage.k8s.io/license: "Apache V2"
8-
cosi.storage.k8s.io/support: "https://github.com/kubernetes-sigs/container-object-storage-api"
9-
controller-gen.kubebuilder.io/version: (devel)
6+
objectstorage.k8s.io/authors: "Kubernetes Authors"
7+
objectstorage.k8s.io/license: "Apache V2"
8+
objectstorage.k8s.io/support: "https://github.com/kubernetes-sigs/container-object-storage-api"
109
api-approved.kubernetes.io: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/1979-object-storage-support
1110

12-
1311
resources:
14-
- crds/objectstorage.k8s.io_bucketaccesses.yaml
15-
- crds/objectstorage.k8s.io_bucketaccessclasses.yaml
16-
- crds/objectstorage.k8s.io_bucketclasses.yaml
17-
- crds/objectstorage.k8s.io_bucketclaims.yaml
18-
- crds/objectstorage.k8s.io_buckets.yaml
12+
- client/config/crd/objectstorage.k8s.io_bucketaccesses.yaml
13+
- client/config/crd/objectstorage.k8s.io_bucketaccessclasses.yaml
14+
- client/config/crd/objectstorage.k8s.io_bucketclasses.yaml
15+
- client/config/crd/objectstorage.k8s.io_bucketclaims.yaml
16+
- client/config/crd/objectstorage.k8s.io_buckets.yaml
17+
- controller

0 commit comments

Comments
 (0)