Address Review

Author: acumino

pkg/client/options.go

@@ -645,7 +645,7 @@ type MatchingLabelsSelector struct {
 // ApplyToList applies this configuration to the given list options.
 func (m MatchingLabelsSelector) ApplyToList(opts *ListOptions) {
 	if m.Selector == nil {
-		m.Selector = labels.Everything()
+		m.Selector = labels.Nothing()
 	}
 	opts.LabelSelector = m
 }
@@ -681,7 +681,7 @@ type MatchingFieldsSelector struct {
 // ApplyToList applies this configuration to the given list options.
 func (m MatchingFieldsSelector) ApplyToList(opts *ListOptions) {
 	if m.Selector == nil {
-		m.Selector = fields.Everything()
+		m.Selector = fields.Nothing()
 	}
 	opts.FieldSelector = m
 }

pkg/client/options_test.go

@@ -44,10 +44,10 @@ var _ = Describe("ListOptions", func() {
 		expectedListOpts := &client.ListOptions{LabelSelector: client.MatchingLabelsSelector{Selector: labelSelector}}
 		Expect(newListOpts).To(Equal(expectedListOpts))
 	})
-	It("Should set LabelSelector to everything with empty MatchingLabelsSelector", func() {
+	It("Should set LabelSelector to nothing with empty MatchingLabelsSelector", func() {
 		newListOpts := &client.ListOptions{}
 		newListOpts.ApplyOptions([]client.ListOption{client.MatchingLabelsSelector{}})
-		expectedListOpts := &client.ListOptions{LabelSelector: client.MatchingLabelsSelector{Selector: labels.Everything()}}
+		expectedListOpts := &client.ListOptions{LabelSelector: client.MatchingLabelsSelector{Selector: labels.Nothing()}}
 		Expect(newListOpts).To(Equal(expectedListOpts))
 	})
 	It("Should set FieldSelector", func() {
@@ -62,10 +62,10 @@ var _ = Describe("ListOptions", func() {
 		expectedListOpts := &client.ListOptions{FieldSelector: client.MatchingFieldsSelector{Selector: fields.Nothing()}}
 		Expect(newListOpts).To(Equal(expectedListOpts))
 	})
-	It("Should set FieldSelector to everything with empty MatchingFieldsSelector", func() {
+	It("Should set FieldSelector to nothing with empty MatchingFieldsSelector", func() {
 		newListOpts := &client.ListOptions{}
 		newListOpts.ApplyOptions([]client.ListOption{client.MatchingFieldsSelector{}})
-		expectedListOpts := &client.ListOptions{FieldSelector: client.MatchingFieldsSelector{Selector: fields.Everything()}}
+		expectedListOpts := &client.ListOptions{FieldSelector: client.MatchingFieldsSelector{Selector: fields.Nothing()}}
 		Expect(newListOpts).To(Equal(expectedListOpts))
 	})
 	It("Should set Namespace", func() {