add another test

Signed-off-by: Troy Connor <[email protected]>

Author: troy0820

tools/setup-envtest/workflows/workflows.go

@@ -96,15 +96,14 @@ type Version struct {
 
 // Do executes the workflow.
 func (v Version) Do(env *envp.Env) {
+	version := "(unknown)"
 	if v.BinaryVersion == "" {
 		info, ok := debug.ReadBuildInfo()
-		if !ok || info == nil || info.Main.Version == "" {
+		if (ok && info != nil) || info.Main.Version != "" {
 			// binary has not been built with module support or doesn't contain a version.
-			fmt.Fprintf(env.Out, "setup-envtest version: %s\n", "(unknown)")
-			return
+			version = fmt.Sprintf("%s", info.Main.Version)
 		}
-		fmt.Fprintf(env.Out, "setup-envtest version: %s\n", info.Main.Version)
-		return
+		v.BinaryVersion = version
 	}
 	fmt.Fprintf(env.Out, "setup-envtest version: %s\n", v.BinaryVersion)
 }

tools/setup-envtest/workflows/workflows_test.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"io/fs"
 	"path/filepath"
+	"runtime/debug"
 	"sort"
 	"strings"
 
@@ -447,11 +448,20 @@ var _ = Describe("Workflows", func() {
 	Describe("version", func() {
 		It("should print out the version based on the Binary Version", func() {
 			v := wf.Version{
-				BinaryVersion: "release-0.18",
+				BinaryVersion: "v0.18.2",
 			}
 			v.Do(env)
 			Expect(out.String()).ToNot(BeEmpty())
-			Expect(out.String()).To(Equal("setup-envtest version: release-0.18\n"))
+			Expect(out.String()).To(Equal("setup-envtest version: v0.18.2\n"))
+		})
+
+		It("should print out the version if the RELEASE_TAG is empty", func() {
+			v := wf.Version{}
+			v.Do(env)
+			info, ok := debug.ReadBuildInfo()
+			Expect(ok).To(BeTrue())
+			Expect(out.String()).ToNot(BeEmpty())
+			Expect(out.String()).To(Equal(fmt.Sprintf("setup-envtest version: %s\n", info.Main.Version)))
 		})
 	})