Fix linting issues

Signed-off-by: Borja Clemente <[email protected]>

Author: clebs

pkg/cluster/cluster_test.go

@@ -158,7 +158,7 @@ var _ = Describe("cluster.Cluster", func() {
 	It("should provide a function to get the EventRecorder", func() {
 		c, err := New(cfg)
 		Expect(err).NotTo(HaveOccurred())
-		Expect(c.GetEventRecorderFor("test")).NotTo(BeNil())
+		Expect(c.GetEventRecorderFor("test")).NotTo(BeNil()) //nolint:staticcheck
 	})
 	It("should provide a function to get the APIReader", func() {
 		c, err := New(cfg)

pkg/internal/recorder/recorder.go

@@ -95,7 +95,7 @@ func (p *Provider) getBroadcaster() events.EventBroadcaster {
 			p.broadcaster = events.NewBroadcaster(&events.EventSinkImpl{Interface: p.evtClient})
 		}
 		// TODO(clebs): figure out how to manage the context/channel that StartRecordingToSink needs inside the provider.
-		p.broadcaster.StartRecordingToSinkWithContext(context.TODO())
+		_ = p.broadcaster.StartRecordingToSinkWithContext(context.TODO())
 	})
 
 	return p.broadcaster

pkg/internal/recorder/recorder_integration_test.go

@@ -43,7 +43,7 @@ var _ = Describe("recorder", func() {
 			Expect(err).NotTo(HaveOccurred())
 
 			By("Creating the Controller")
-			recorder := cm.GetEventRecorderFor("test-recorder")
+			recorder := cm.GetEventRecorderFor("test-recorder") //nolint:staticcheck
 			instance, err := controller.New("foo-controller", cm, controller.Options{
 				Reconciler: reconcile.Func(
 					func(ctx context.Context, request reconcile.Request) (reconcile.Result, error) {

pkg/leaderelection/leader_election.go

@@ -128,7 +128,7 @@ func NewResourceLock(config *rest.Config, recorderProvider recorder.Provider, op
 		coordinationClient,
 		resourcelock.ResourceLockConfig{
 			Identity:      id,
-			EventRecorder: recorderProvider.GetEventRecorderFor(id),
+			EventRecorder: recorderProvider.GetEventRecorderFor(id), //nolint:staticcheck
 		},
 		options.LeaderLabels,
 	)

pkg/manager/internal.go

@@ -257,7 +257,7 @@ func (cm *controllerManager) GetCache() cache.Cache {
 }
 
 func (cm *controllerManager) GetEventRecorderFor(name string) record.EventRecorder {
-	return cm.cluster.GetEventRecorderFor(name)
+	return cm.cluster.GetEventRecorderFor(name) //nolint:staticcheck
 }
 
 func (cm *controllerManager) GetEventRecorder(name string) events.EventRecorder {

pkg/manager/manager.go

@@ -322,10 +322,7 @@ func New(config *rest.Config, options Options) (Manager, error) {
 		return nil, errors.New("must specify Config")
 	}
 	// Set default values for options fields
-	options, err := setOptionsDefaults(config, options)
-	if err != nil {
-		return nil, err
-	}
+	options = setOptionsDefaults(config, options)
 
 	cluster, err := cluster.New(config, func(clusterOptions *cluster.Options) {
 		clusterOptions.Scheme = options.Scheme
@@ -481,7 +478,7 @@ func defaultBaseContext() context.Context {
 }
 
 // setOptionsDefaults set default values for Options fields.
-func setOptionsDefaults(config *rest.Config, options Options) (Options, error) {
+func setOptionsDefaults(_ *rest.Config, options Options) Options {
 	// Allow newResourceLock to be mocked
 	if options.newResourceLock == nil {
 		options.newResourceLock = leaderelection.NewResourceLock
@@ -545,5 +542,5 @@ func setOptionsDefaults(config *rest.Config, options Options) (Options, error) {
 		options.WebhookServer = webhook.NewServer(webhook.Options{})
 	}
 
-	return options, nil
+	return options
 }

pkg/manager/manager_test.go

@@ -1862,7 +1862,7 @@ var _ = Describe("manger.Manager", func() {
 		ns := corev1.Namespace{}
 		ns.Name = "default"
 
-		recorder := m.GetEventRecorderFor("rock-and-roll")
+		recorder := m.GetEventRecorderFor("rock-and-roll") //nolint:staticcheck
 		Expect(m.Add(RunnableFunc(func(_ context.Context) error {
 			recorder.Event(&ns, "Warning", "BallroomBlitz", "yeah, yeah, yeah-yeah-yeah")
 			return nil
@@ -1935,7 +1935,7 @@ var _ = Describe("manger.Manager", func() {
 	It("should provide a function to get the EventRecorder", func() {
 		m, err := New(cfg, Options{})
 		Expect(err).NotTo(HaveOccurred())
-		Expect(m.GetEventRecorderFor("test")).NotTo(BeNil())
+		Expect(m.GetEventRecorderFor("test")).NotTo(BeNil()) //nolint:staticcheck
 	})
 	It("should provide a function to get the APIReader", func() {
 		m, err := New(cfg, Options{})