Fake client should set CreationTimestamp

Author: fabriziopandini

pkg/client/fake/client.go

@@ -933,6 +933,14 @@ func (c *fakeClient) patch(obj client.Object, patch client.Patch, opts ...client
 			// Overwrite it unconditionally, this matches the apiserver behavior
 			// which allows to set it on create, but will then ignore it.
 			obj.SetResourceVersion("1")
+
+			now, err := time.Parse(time.RFC3339, time.Now().Format(time.RFC3339))
+			if err != nil {
+				return apierrors.NewInternalError(err)
+			}
+			obj.SetCreationTimestamp(metav1.Time{
+				Time: now,
+			})
 		} else {
 			// SSA deletionTimestamp updates are silently ignored
 			obj.SetDeletionTimestamp(oldAccessor.GetDeletionTimestamp())

pkg/client/fake/client_test.go

@@ -414,6 +414,7 @@ var _ = Describe("Fake client", func() {
 			Expect(err).ToNot(HaveOccurred())
 			Expect(obj).To(Equal(newcm))
 			Expect(obj.ObjectMeta.ResourceVersion).To(Equal("1"))
+			Expect(obj.ObjectMeta.CreationTimestamp.IsZero()).To(BeFalse())
 		})
 
 		It("should error on create with set resourceVersion", func(ctx SpecContext) {
@@ -429,6 +430,19 @@ var _ = Describe("Fake client", func() {
 			Expect(apierrors.IsBadRequest(err)).To(BeTrue())
 		})
 
+		It("should error on create with set creationTimestamp", func(ctx SpecContext) {
+			By("Creating a new configmap")
+			newcm := &corev1.ConfigMap{
+				ObjectMeta: metav1.ObjectMeta{
+					Name:              "new-test-cm",
+					Namespace:         "ns2",
+					CreationTimestamp: metav1.Now(),
+				},
+			}
+			err := cl.Create(ctx, newcm)
+			Expect(apierrors.IsBadRequest(err)).To(BeTrue())
+		})
+
 		It("should not change the submitted object if Create failed", func(ctx SpecContext) {
 			By("Trying to create an existing configmap")
 			submitted := cm.DeepCopy()
@@ -3068,6 +3082,16 @@ var _ = Describe("Fake client", func() {
 		Expect(obj.ResourceVersion).To(BeEquivalentTo(ptr.To("1")))
 	})
 
+	It("sets creatioTimestamp on SSA create", func(ctx SpecContext) {
+		obj := corev1applyconfigurations.
+			ConfigMap("foo", "default").
+			WithData(map[string]string{"some": "data"})
+
+		cl := NewClientBuilder().Build()
+		Expect(cl.Apply(ctx, obj, client.FieldOwner("foo"))).NotTo(HaveOccurred())
+		Expect(obj.CreationTimestamp.IsZero()).To(BeFalse())
+	})
+
 	It("ignores a passed resourceVersion on SSA create", func(ctx SpecContext) {
 		obj := corev1applyconfigurations.
 			ConfigMap("foo", "default").

pkg/client/fake/versioned_tracker.go

@@ -20,8 +20,10 @@ import (
 	"bytes"
 	"errors"
 	"fmt"
+	"reflect"
 	"runtime/debug"
 	"strconv"
+	"time"
 
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/meta"
@@ -34,6 +36,7 @@ import (
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	"k8s.io/apimachinery/pkg/watch"
 	"k8s.io/client-go/testing"
+
 	"sigs.k8s.io/controller-runtime/pkg/client/apiutil"
 )
 
@@ -111,12 +114,23 @@ func (t versionedTracker) Create(gvr schema.GroupVersionResource, obj runtime.Ob
 		return apierrors.NewBadRequest("resourceVersion can not be set for Create requests")
 	}
 	accessor.SetResourceVersion("1")
+	if !reflect.DeepEqual(accessor.GetCreationTimestamp(), metav1.Time{}) {
+		return apierrors.NewBadRequest("creationTimestamp can not be set for Create requests")
+	}
+	now, err := time.Parse(time.RFC3339, time.Now().Format(time.RFC3339))
+	if err != nil {
+		return apierrors.NewInternalError(err)
+	}
+	accessor.SetCreationTimestamp(metav1.Time{
+		Time: now,
+	})
 	obj, err = convertFromUnstructuredIfNecessary(t.scheme, obj)
 	if err != nil {
 		return err
 	}
 	if err := t.upstream.Create(gvr, obj, ns, opts...); err != nil {
 		accessor.SetResourceVersion("")
+		accessor.SetCreationTimestamp(metav1.Time{})
 		return err
 	}