rm metricsAscend flag

moritzmoe · moritzmoe · commit b8e2760112e4 · 2025-10-02T17:32:11.000+02:00
diff --git a/pkg/controller/priorityqueue/priorityqueue.go b/pkg/controller/priorityqueue/priorityqueue.go
@@ -239,7 +239,6 @@ func (w *priorityqueue[T]) spin() {
 			}
 
 			for {
-				metricsAscend := false
 				pivotChange := false
 
 				w.queue.AscendGreaterOrEqual(&pivot, func(item *item[T]) bool {
@@ -265,8 +264,7 @@ func (w *priorityqueue[T]) spin() {
 						}
 					}
 
-					if w.waiters.Load() == 0 || metricsAscend {
-						metricsAscend = true
+					if w.waiters.Load() == 0 {
 						// Have to keep iterating here to ensure we update metrics
 						// for further items that became ready and set nextReady.
 						return true

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,6 @@ func (w *priorityqueue[T]) spin() {`
`239`	`239`	`}`
`240`	`240`
`241`	`241`	`for {`
`242`		`- metricsAscend := false`
`243`	`242`	`pivotChange := false`
`244`	`243`
`245`	`244`	`w.queue.AscendGreaterOrEqual(&pivot, func(item *item[T]) bool {`
`@@ -265,8 +264,7 @@ func (w *priorityqueue[T]) spin() {`
`265`	`264`	`}`
`266`	`265`	`}`
`267`	`266`
`268`		`- if w.waiters.Load() == 0 \|\| metricsAscend {`
`269`		`- metricsAscend = true`
	`267`	`+ if w.waiters.Load() == 0 {`
`270`	`268`	`// Have to keep iterating here to ensure we update metrics`
`271`	`269`	`// for further items that became ready and set nextReady.`
`272`	`270`	`return true`