Fix lint.

Author: godwinpang

pkg/controller/controller.go

@@ -260,7 +260,7 @@ func NewTypedUnmanaged[request comparable](name string, options TypedOptions[req
 	}
 
 	// Create controller with dependencies set
-	return controller.New[request](controller.ControllerOptions[request]{
+	return controller.New[request](controller.Options[request]{
 		Do:                      options.Reconciler,
 		RateLimiter:             options.RateLimiter,
 		NewQueue:                options.NewQueue,

pkg/internal/controller/controller.go

@@ -38,7 +38,8 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/source"
 )
 
-type ControllerOptions[request comparable] struct {
+// Options are the arguments for creating a new Controller.
+type Options[request comparable] struct {
 	// Reconciler is a function that can be called at any time with the Name / Namespace of an object and
 	// ensures that the state of the system matches the state specified in the object.
 	// Defaults to the DefaultReconcileFunc.
@@ -129,7 +130,7 @@ type Controller[request comparable] struct {
 
 	// startedEventSources is used to track if the event sources have been started.
 	// It ensures that we append sources to c.startWatches only until we call Start() / Warmup()
-    // It is true if startEventSourcesLocked has been called at least once.
+	// It is true if startEventSourcesLocked has been called at least once.
 	startedEventSources bool
 
 	// didStartEventSourcesOnce is used to ensure that the event sources are only started once.
@@ -162,7 +163,8 @@ type Controller[request comparable] struct {
 	EnableWarmup *bool
 }
 
-func New[request comparable](options ControllerOptions[request]) *Controller[request] {
+// New returns a new Controller configured with the given options.
+func New[request comparable](options Options[request]) *Controller[request] {
 	return &Controller[request]{
 		Do:                      options.Do,
 		RateLimiter:             options.RateLimiter,

pkg/internal/controller/controller_test.go

@@ -72,7 +72,7 @@ var _ = Describe("controller", func() {
 		queue = &controllertest.Queue{
 			TypedInterface: workqueue.NewTyped[reconcile.Request](),
 		}
-		ctrl = New[reconcile.Request](ControllerOptions[reconcile.Request]{
+		ctrl = New[reconcile.Request](Options[reconcile.Request]{
 			MaxConcurrentReconciles: 1,
 			Do:                      fakeReconcile,
 			NewQueue: func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {
@@ -353,7 +353,7 @@ var _ = Describe("controller", func() {
 				TypedRateLimitingInterface: &controllertest.TypedQueue[TestRequest]{
 					TypedInterface: workqueue.NewTyped[TestRequest](),
 				}}
-			ctrl := New[TestRequest](ControllerOptions[TestRequest]{
+			ctrl := New[TestRequest](Options[TestRequest]{
 				NewQueue: func(string, workqueue.TypedRateLimiter[TestRequest]) workqueue.TypedRateLimitingInterface[TestRequest] {
 					return queue
 				},
@@ -1192,7 +1192,7 @@ var _ = Describe("controller", func() {
 				}),
 			}
 
-			nonWarmupCtrl := New[reconcile.Request](ControllerOptions[reconcile.Request]{
+			nonWarmupCtrl := New[reconcile.Request](Options[reconcile.Request]{
 				MaxConcurrentReconciles: 1,
 				Do:                      fakeReconcile,
 				NewQueue: func(string, workqueue.TypedRateLimiter[reconcile.Request]) workqueue.TypedRateLimitingInterface[reconcile.Request] {