Skip to content

Commit fcdeca4

Browse files
tarekshak8s-infra-cherrypick-robot
authored andcommitted
🐛fix(controller): use generic WaitForSync
There is already support for defining `TypedSyncingSource` but the original code still checks for the original `SyncingSource` before callign `WaitForSync(ctx)` which does not work for custom typed controller. this fix should be backported to v0.19
1 parent 571c31a commit fcdeca4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/internal/controller/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ func (c *Controller[request]) Start(ctx context.Context) error {
200200
sourceStartErrChan <- err
201201
return
202202
}
203-
syncingSource, ok := watch.(source.SyncingSource)
203+
syncingSource, ok := watch.(source.TypedSyncingSource[request])
204204
if !ok {
205205
return
206206
}

0 commit comments

Comments
 (0)