Skip to content

infra bug: PR tests are running linter twice in tests and separate action #3325

@dmvolod

Description

@dmvolod

There are separate lint PR action which is running golangci-lint, however, pull-controller-runtime-test action also running linter again via hack/check-everything.sh script. Once tests are happy, but linter not, there are errors in the test action

go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
/home/prow/go/src/sigs.k8s.io/controller-runtime/hack/tools/bin/golangci-lint-v2.4.0 run -v 
level=info msg="golangci-lint has version 2.4.0 built with go1.24.0 from (unknown, modified: ?, mod sum: \"h1:qz6O6vr7kVzXJqyvHjHSz5fA3D+PM8v96QU5gxZCNWM=\") on (unknown)"
level=info msg="[config_reader] Config search paths: [./ /home/prow/go/src/sigs.k8s.io/controller-runtime /home/prow/go/src/sigs.k8s.io /home/prow/go/src /home/prow/go /home/prow /home / /root]"
level=info msg="[config_reader] Used config file .golangci.yml"
level=info msg="maxprocs: Updating GOMAXPROCS=7: determined from CPU quota"
level=info msg="[goenv] Read go env for 15.239706ms: map[string]string{\"GOCACHE\":\"/root/.cache/go-build\", \"GOROOT\":\"/home/prow/go/pkg/mod/golang.org/[email protected]\"}"

https://prow.k8s.io/log?container=test&id=1970913105017835520&job=pull-controller-runtime-test

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions