⚠️ Fakeclient: Fix a number of bugs when updating through apply #3319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaroaleman
added
the
tide/merge-method-squash
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
alvaroaleman
changed the title
k8s-ci-robot
added
the
size/XL
alvaroaleman
force-pushed
the
fakestatus
branch
from
7aee523 to
e5e79f5
Compare
alvaroaleman
force-pushed
the
fakestatus
branch
2 times, most recently
from
8e536d1 to
a8c73d7
Compare
sbueringer
reviewed
Sep 17, 2025
alvaroaleman
force-pushed
the
fakestatus
branch
from
a8c73d7 to
535ae6b
Compare
Member
|
Thank you very much! /lgtm |
k8s-ci-robot
added
lgtm
Contributor
|
LGTM label has been added. Git tree hash: 52f5bd390f08a0938a3e8958ab16b46c962b664e
|
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this, updates through Apply did not call
versionedTracker.updateObjectwhich does a number of things such as:The reason this happend is that
versionedTrackerembedded antesting.ObjectTrackerand as a result, we inherited theApplyof that upstream tracker rather than implementing our own.This PR contains three commits:
versionedTrackerinto its own fileversionedTrackeratesting.ObjectTrackerand stop embedding its upstreamupdateObjectfrom the versioned trackersApplyand update things as needed, as well as adding tests/assign @sbueringer
/hold