Merge pull request #420 from djzager/webhookbug

k8s-ci-robot · web-flow · commit 15412e27a156 · 2020-03-18T09:32:48.000-07:00
🐛 do not error when webhook matchpolicy unset
diff --git a/pkg/webhook/parser.go b/pkg/webhook/parser.go
@@ -194,6 +194,8 @@ func (c Config) matchPolicy() (*admissionreg.MatchPolicyType, error) {
 		matchPolicy = admissionreg.Exact
 	case strings.ToLower(string(admissionreg.Equivalent)):
 		matchPolicy = admissionreg.Equivalent
+	case "":
+		return nil, nil
 	default:
 		return nil, fmt.Errorf("unknown value %q for matchPolicy", c.MatchPolicy)
 	}

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,8 @@ func (c Config) matchPolicy() (*admissionreg.MatchPolicyType, error) {`
`194`	`194`	`matchPolicy = admissionreg.Exact`
`195`	`195`	`case strings.ToLower(string(admissionreg.Equivalent)):`
`196`	`196`	`matchPolicy = admissionreg.Equivalent`
	`197`	`+ case "":`
	`198`	`+ return nil, nil`
`197`	`199`	`default:`
`198`	`200`	`return nil, fmt.Errorf("unknown value %q for matchPolicy", c.MatchPolicy)`
`199`	`201`	`}`