Skip to content

Commit 1d66658

Browse files
committed
link to embedded ObjectMeta discussion
Signed-off-by: Blaine Gardner <[email protected]>
1 parent adfbf77 commit 1d66658

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

pkg/crd/gen.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,9 +286,7 @@ func FixTopLevelMetadata(crd apiext.CustomResourceDefinition) {
286286
schemaProperties["metadata"] = apiext.JSONSchemaProps{Type: "object"}
287287
}
288288
}
289-
290289
}
291-
292290
}
293291

294292
// toTrivialVersions strips out all schemata except for the storage schema,

pkg/crd/known_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@ var ObjectMetaPackages = map[string]PackageOverride{
118118
if f, ok := KnownPackages["k8s.io/apimachinery/pkg/apis/meta/v1"]; ok {
119119
f(p, pkg)
120120
}
121-
// This is a allow-listed set of properties of ObjectMeta, other runtime properties are not part of this list
121+
// This is an allow-listed set of properties of ObjectMeta, other runtime properties are not part of this list
122+
// See more discussion: https://github.com/kubernetes-sigs/controller-tools/pull/395#issuecomment-691919433
122123
p.Schemata[TypeIdent{Name: "ObjectMeta", Package: pkg}] = apiext.JSONSchemaProps{
123124
Type: "object",
124125
Properties: map[string]apiext.JSONSchemaProps{

0 commit comments

Comments
 (0)