Skip to content

Commit 3654ffc

Browse files
committed
Use +kubebuilder:skip=true to skip package
Signed-off-by: Tamal Saha <[email protected]>
1 parent 76a25b6 commit 3654ffc

File tree

3 files changed

+19
-8
lines changed

3 files changed

+19
-8
lines changed

pkg/crd/markers/package.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,8 @@ func init() {
3333

3434
must(markers.MakeDefinition("kubebuilder:validation:Required", markers.DescribesPackage, struct{}{})).
3535
WithHelp(markers.SimpleHelp("CRD validation", "specifies that all fields in this package are required by default.")),
36+
37+
must(markers.MakeDefinition("kubebuilder:skip", markers.DescribesPackage, false)).
38+
WithHelp(markers.SimpleHelp("CRD", "skip this package.")),
3639
)
3740
}

pkg/crd/parser.go

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,22 @@ func (p *Parser) indexTypes(pkg *loader.Package) {
110110
pkgMarkers, err := markers.PackageMarkers(p.Collector, pkg)
111111
if err != nil {
112112
pkg.AddError(err)
113-
} else if nameVal := pkgMarkers.Get("groupName"); nameVal != nil {
114-
versionVal := pkg.Name // a reasonable guess
115-
if versionMarker := pkgMarkers.Get("versionName"); versionMarker != nil {
116-
versionVal = versionMarker.(string)
113+
} else {
114+
if skipPkg := pkgMarkers.Get("kubebuilder:skip"); skipPkg != nil {
115+
if skipPkg.(bool) {
116+
return
117+
}
117118
}
118-
119-
p.GroupVersions[pkg] = schema.GroupVersion{
120-
Version: versionVal,
121-
Group: nameVal.(string),
119+
if nameVal := pkgMarkers.Get("groupName"); nameVal != nil {
120+
versionVal := pkg.Name // a reasonable guess
121+
if versionMarker := pkgMarkers.Get("versionName"); versionMarker != nil {
122+
versionVal = versionMarker.(string)
123+
}
124+
125+
p.GroupVersions[pkg] = schema.GroupVersion{
126+
Version: versionVal,
127+
Group: nameVal.(string),
128+
}
122129
}
123130
}
124131

pkg/crd/testdata/cronjob_types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717

1818
// +groupName=testdata.kubebuilder.io
1919
// +versionName=v1
20+
// +kubebuilder:skip=true
2021
package cronjob
2122

2223
import (

0 commit comments

Comments
 (0)