Skip to content

Commit 7483ddc

Browse files
authored
Merge pull request #1003 from eddycharly/use-ptr
🏃 use ptr package
2 parents b07ad66 + 0adb7e1 commit 7483ddc

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ require (
1616
k8s.io/api v0.30.2
1717
k8s.io/apiextensions-apiserver v0.30.2
1818
k8s.io/apimachinery v0.30.2
19+
k8s.io/utils v0.0.0-20230726121419-3b25d923346b
1920
sigs.k8s.io/yaml v1.4.0
2021
)
2122

@@ -39,7 +40,6 @@ require (
3940
gopkg.in/inf.v0 v0.9.1 // indirect
4041
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
4142
k8s.io/klog/v2 v2.120.1 // indirect
42-
k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect
4343
sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
4444
sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
4545
)

pkg/crd/known_types.go

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ package crd
1717

1818
import (
1919
apiext "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
20+
"k8s.io/utils/ptr"
2021

2122
"sigs.k8s.io/controller-tools/pkg/loader"
2223
)
@@ -75,7 +76,7 @@ var KnownPackages = map[string]PackageOverride{
7576
p.Schemata[TypeIdent{Name: "RawExtension", Package: pkg}] = apiext.JSONSchemaProps{
7677
// TODO(directxman12): regexp validation for this (or get kube to support it as a format value)
7778
Type: "object",
78-
XPreserveUnknownFields: boolPtr(true),
79+
XPreserveUnknownFields: ptr.To(true),
7980
}
8081
p.AddPackage(pkg) // get the rest of the types
8182
},
@@ -100,13 +101,13 @@ var KnownPackages = map[string]PackageOverride{
100101

101102
"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1": func(p *Parser, pkg *loader.Package) {
102103
p.Schemata[TypeIdent{Name: "JSON", Package: pkg}] = apiext.JSONSchemaProps{
103-
XPreserveUnknownFields: boolPtr(true),
104+
XPreserveUnknownFields: ptr.To(true),
104105
}
105106
p.AddPackage(pkg) // get the rest of the types
106107
},
107108
"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1": func(p *Parser, pkg *loader.Package) {
108109
p.Schemata[TypeIdent{Name: "JSON", Package: pkg}] = apiext.JSONSchemaProps{
109-
XPreserveUnknownFields: boolPtr(true),
110+
XPreserveUnknownFields: ptr.To(true),
110111
}
111112
p.AddPackage(pkg) // get the rest of the types
112113
},
@@ -159,10 +160,6 @@ var ObjectMetaPackages = map[string]PackageOverride{
159160
},
160161
}
161162

162-
func boolPtr(b bool) *bool {
163-
return &b
164-
}
165-
166163
// AddKnownTypes registers the packages overrides in KnownPackages with the given parser.
167164
func AddKnownTypes(parser *Parser) {
168165
// ensure everything is there before adding to PackageOverrides

0 commit comments

Comments
 (0)