Fix linting issues

Author: JoelSpeed

pkg/applyconfigurations/applyconfiguration_integration_test.go

@@ -21,7 +21,6 @@ import (
 	"io"
 	"io/fs"
 	"os"
-	"sort"
 	"strings"
 
 	. "github.com/onsi/ginkgo"
@@ -44,15 +43,6 @@ func (m outputToMap) Open(_ *loader.Package, path string) (io.WriteCloser, error
 	return m[path], nil
 }
 
-func (m outputToMap) fileList() []string {
-	ret := make([]string, 0, len(m))
-	for path := range m {
-		ret = append(ret, path)
-	}
-	sort.Strings(ret)
-	return ret
-}
-
 type outputFile struct {
 	contents []byte
 }

pkg/applyconfigurations/gen.go

@@ -55,8 +55,6 @@ const importPathSuffix = "applyconfiguration"
 type Generator struct {
 	// HeaderFile specifies the header text (e.g. license) to prepend to generated files.
 	HeaderFile string `marker:",optional"`
-
-	outputPath string
 }
 
 func (Generator) CheckFilter() loader.NodeFilter {
@@ -166,15 +164,15 @@ func (u *Universe) existingApplyConfigPath(_ *types.Named, pkgPath string) (stri
 	return "", false
 }
 
-func (u *Universe) IsApplyConfigGenerated(typeInfo *types.Named, pkgPath string) bool {
+func (u *Universe) IsApplyConfigGenerated(typeInfo *types.Named) bool {
 	if t, ok := u.typeMetadata[typeInfo]; ok {
 		return t.used
 	}
 	return false
 }
 
 func (u *Universe) GetApplyConfigPath(typeInfo *types.Named, pkgPath string) (string, bool) {
-	isApplyConfigGenerated := u.IsApplyConfigGenerated(typeInfo, pkgPath)
+	isApplyConfigGenerated := u.IsApplyConfigGenerated(typeInfo)
 	if path, ok := u.existingApplyConfigPath(typeInfo, pkgPath); ok {
 		if isApplyConfigGenerated {
 			return path, true
@@ -251,7 +249,7 @@ func (ctx *ObjectGenCtx) generateForPackage(root *loader.Package) error {
 
 	packages := applygenerator.Packages(c, genericArgs)
 	if err := c.ExecutePackages(genericArgs.OutputBase, packages); err != nil {
-		return err
+		return fmt.Errorf("error executing packages: %w", err)
 	}
 
 	return nil