Merge pull request #344 from dsbrng25b/master

k8s-ci-robot · web-flow · commit a1c859b129e5 · 2020-01-24T16:53:02.000-08:00
✨ Do not create empty webhook/manifests.yaml file
diff --git a/pkg/webhook/parser.go b/pkg/webhook/parser.go
@@ -242,8 +242,8 @@ func (Generator) Generate(ctx *genall.GenerationContext) error {
 
 	}
 
-	if err := ctx.WriteYAML("manifests.yaml", objs...); err != nil {
-		return err
+	if len(objs) > 0 {
+		return ctx.WriteYAML("manifests.yaml", objs...)
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -242,8 +242,8 @@ func (Generator) Generate(ctx *genall.GenerationContext) error {`
`242`	`242`
`243`	`243`	`}`
`244`	`244`
`245`		`- if err := ctx.WriteYAML("manifests.yaml", objs...); err != nil {`
`246`		`- return err`
	`245`	`+ if len(objs) > 0 {`
	`246`	`+ return ctx.WriteYAML("manifests.yaml", objs...)`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`return nil`