Skip to content

Commit b4e73da

Browse files
authored
Merge pull request #314 from daneharrigan/add-int64-to-builtinToType-comments
📖Update builtinToType comments to explain support for int32 and int64
2 parents ba11932 + 9c56aac commit b4e73da

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/crd/schema.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -389,8 +389,8 @@ func structToSchema(ctx *schemaContext, structType *ast.StructType) *v1beta1.JSO
389389
}
390390

391391
// builtinToType converts builtin basic types to their equivalent JSON schema form.
392-
// It *only* handles types allowed by the kubernetes API standards, meaning
393-
// no floats (technically we shouldn't allow int64 or plain int either, but :shrug:).
392+
// It *only* handles types allowed by the kubernetes API standards. Floats are not
393+
// allowed.
394394
func builtinToType(basic *types.Basic) (typ string, format string, err error) {
395395
// NB(directxman12): formats from OpenAPI v3 are slightly different than those defined
396396
// in JSONSchema. This'll use the OpenAPI v3 ones, since they're useful for bounding our

0 commit comments

Comments
 (0)