Skip to content

Commit 333cf18

Browse files
authored
Merge pull request #5292 from kubernetes-sigs/raffo/change-yaml-dep
chore(deps): switch to goccy yaml
2 parents 2de3b50 + 3e9f464 commit 333cf18

File tree

7 files changed

+15
-13
lines changed

7 files changed

+15
-13
lines changed

go.mod

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ require (
3737
github.com/ffledgling/pdns-go v0.0.0-20180219074714-524e7daccd99
3838
github.com/go-gandi/go-gandi v0.7.0
3939
github.com/go-logr/logr v1.4.2
40+
github.com/goccy/go-yaml v1.17.1
4041
github.com/google/go-cmp v0.7.0
4142
github.com/google/uuid v1.6.0
4243
github.com/linki/instrumented_http v0.3.0
@@ -69,9 +70,7 @@ require (
6970
golang.org/x/text v0.24.0
7071
golang.org/x/time v0.11.0
7172
google.golang.org/api v0.228.0
72-
gopkg.in/ns1/ns1-go.v2 v2.14.1
73-
gopkg.in/yaml.v2 v2.4.0
74-
gopkg.in/yaml.v3 v3.0.1
73+
gopkg.in/ns1/ns1-go.v2 v2.14.2
7574
istio.io/api v1.25.1
7675
istio.io/client-go v1.25.1
7776
k8s.io/api v0.32.3
@@ -212,6 +211,8 @@ require (
212211
gopkg.in/inf.v0 v0.9.1 // indirect
213212
gopkg.in/ini.v1 v1.67.0 // indirect
214213
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 // indirect
214+
gopkg.in/yaml.v2 v2.4.0 // indirect
215+
gopkg.in/yaml.v3 v3.0.1 // indirect
215216
k8s.io/kube-openapi v0.0.0-20241105132330-32ad38e42d3f // indirect
216217
k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738 // indirect
217218
moul.io/http2curl v1.0.0 // indirect

go.sum

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,8 @@ github.com/gobwas/glob v0.2.3/go.mod h1:d3Ez4x06l9bZtSvzIay5+Yzi0fmZzPgnTbPcKjJA
439439
github.com/goccy/go-json v0.7.8/go.mod h1:6MelG93GURQebXPDq3khkgXZkazVtN9CRI+MGFi0w8I=
440440
github.com/goccy/go-json v0.10.5 h1:Fq85nIqj+gXn/S5ahsiTlK3TmC85qgirsdTP/+DeaC4=
441441
github.com/goccy/go-json v0.10.5/go.mod h1:oq7eo15ShAhp70Anwd5lgX2pLfOS3QCiwU/PULtXL6M=
442+
github.com/goccy/go-yaml v1.17.1 h1:LI34wktB2xEE3ONG/2Ar54+/HJVBriAGJ55PHls4YuY=
443+
github.com/goccy/go-yaml v1.17.1/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
442444
github.com/godbus/dbus v0.0.0-20190422162347-ade71ed3457e/go.mod h1:bBOAhwG1umN6/6ZUMtDFBMQR8jRg9O75tm9K00oMsK4=
443445
github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=
444446
github.com/godror/godror v0.13.3/go.mod h1:2ouUT4kdhUBk7TAkHWD4SN0CdI0pgEQbo8FVHhbSKWg=
@@ -1449,8 +1451,8 @@ gopkg.in/ini.v1 v1.51.1/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
14491451
gopkg.in/ini.v1 v1.67.0 h1:Dgnx+6+nfE+IfzjUEISNeydPJh9AXNNsWbGP9KzCsOA=
14501452
gopkg.in/ini.v1 v1.67.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k=
14511453
gopkg.in/natefinch/lumberjack.v2 v2.0.0/go.mod h1:l0ndWWf7gzL7RNwBG7wST/UCcT4T24xpD6X8LsfU/+k=
1452-
gopkg.in/ns1/ns1-go.v2 v2.14.1 h1:wruE2g1uB90kMW+jHW8BtWa1HvNkqDfyf7SacTKWtBY=
1453-
gopkg.in/ns1/ns1-go.v2 v2.14.1/go.mod h1:pfaU0vECVP7DIOr453z03HXS6dFJpXdNRwOyRzwmPSc=
1454+
gopkg.in/ns1/ns1-go.v2 v2.14.2 h1:wz/toj9U20wBrmYxW4vTz7sZWED+JJVRjUBBJ7CKrzI=
1455+
gopkg.in/ns1/ns1-go.v2 v2.14.2/go.mod h1:pfaU0vECVP7DIOr453z03HXS6dFJpXdNRwOyRzwmPSc=
14541456
gopkg.in/resty.v1 v1.12.0/go.mod h1:mDo4pnntr5jdWRML875a/NmxYqAlA73dVijT2AXvQQo=
14551457
gopkg.in/square/go-jose.v2 v2.2.2/go.mod h1:M9dMgbHiYLoDGQrXy7OpJDJWiKiU//h+vD76mk0e1AI=
14561458
gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7 h1:uRGJdciOHaEIrze2W8Q3AKkepLTh2hOroT7a+7czfdQ=

provider/alibabacloud/alibaba_cloud.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ import (
2929
"github.com/aliyun/alibaba-cloud-sdk-go/services/alidns"
3030
"github.com/aliyun/alibaba-cloud-sdk-go/services/pvtz"
3131
"github.com/denverdino/aliyungo/metadata"
32+
yaml "github.com/goccy/go-yaml"
3233
log "github.com/sirupsen/logrus"
33-
"gopkg.in/yaml.v2"
3434

3535
"sigs.k8s.io/external-dns/endpoint"
3636
"sigs.k8s.io/external-dns/plan"

provider/aws/aws_utils_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ import (
2424

2525
"github.com/aws/aws-sdk-go-v2/service/route53"
2626
route53types "github.com/aws/aws-sdk-go-v2/service/route53/types"
27+
yaml "github.com/goccy/go-yaml"
2728
"github.com/stretchr/testify/assert"
28-
"gopkg.in/yaml.v3"
2929
"sigs.k8s.io/external-dns/endpoint"
3030
"sigs.k8s.io/external-dns/provider"
3131
)

provider/azure/config.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ limitations under the License.
1717
package azure
1818

1919
import (
20+
"encoding/json"
2021
"fmt"
2122
"os"
2223
"strings"
@@ -26,7 +27,6 @@ import (
2627
"github.com/Azure/azure-sdk-for-go/sdk/azcore/cloud"
2728
"github.com/Azure/azure-sdk-for-go/sdk/azidentity"
2829
log "github.com/sirupsen/logrus"
29-
"gopkg.in/yaml.v2"
3030
)
3131

3232
// config represents common config items for Azure DNS and Azure Private DNS
@@ -50,9 +50,8 @@ func getConfig(configFile, subscriptionID, resourceGroup, userAssignedIdentityCl
5050
return nil, fmt.Errorf("failed to read Azure config file '%s': %v", configFile, err)
5151
}
5252
cfg := &config{}
53-
err = yaml.Unmarshal(contents, &cfg)
54-
if err != nil {
55-
return nil, fmt.Errorf("failed to read Azure config file '%s': %v", configFile, err)
53+
if err := json.Unmarshal(contents, &cfg); err != nil {
54+
return nil, fmt.Errorf("failed to parse Azure config file '%s': %v", configFile, err)
5655
}
5756
// If a subscription ID was given, override what was present in the config file
5857
if subscriptionID != "" {

provider/ibmcloud/ibmcloud.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ import (
2929
"github.com/IBM/networking-go-sdk/dnsrecordsv1"
3030
"github.com/IBM/networking-go-sdk/dnssvcsv1"
3131
"github.com/IBM/networking-go-sdk/zonesv1"
32-
"gopkg.in/yaml.v2"
32+
yaml "github.com/goccy/go-yaml"
3333

3434
log "github.com/sirupsen/logrus"
3535

provider/oci/oci.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ import (
2323
"strings"
2424
"time"
2525

26+
yaml "github.com/goccy/go-yaml"
2627
"github.com/oracle/oci-go-sdk/v65/common"
2728
"github.com/oracle/oci-go-sdk/v65/common/auth"
2829
"github.com/oracle/oci-go-sdk/v65/dns"
2930
"github.com/pkg/errors"
3031
log "github.com/sirupsen/logrus"
31-
yaml "gopkg.in/yaml.v2"
3232

3333
"sigs.k8s.io/external-dns/endpoint"
3434
"sigs.k8s.io/external-dns/plan"

0 commit comments

Comments
 (0)