Fix typo in variable names

BenjaminBraunDev · BenjaminBraunDev · commit 0174f0b87937 · 2025-09-27T00:47:55.000Z
diff --git a/pkg/epp/handlers/response.go b/pkg/epp/handlers/response.go
@@ -93,7 +93,7 @@ func (s *StreamingServer) HandleResponseHeaders(ctx context.Context, reqCtx *Req
 		}
 	}
 
-	reqCtx, err := s.director.HandleResponseRecieved(ctx, reqCtx)
+	reqCtx, err := s.director.HandleResponseReceived(ctx, reqCtx)
 
 	return reqCtx, err
 }
diff --git a/pkg/epp/handlers/server.go b/pkg/epp/handlers/server.go
@@ -54,7 +54,7 @@ func NewStreamingServer(datastore Datastore, director Director) *StreamingServer
 
 type Director interface {
 	HandleRequest(ctx context.Context, reqCtx *RequestContext) (*RequestContext, error)
-	HandleResponseRecieved(ctx context.Context, reqCtx *RequestContext) (*RequestContext, error)
+	HandleResponseReceived(ctx context.Context, reqCtx *RequestContext) (*RequestContext, error)
 	HandleResponseBodyStreaming(ctx context.Context, reqCtx *RequestContext) (*RequestContext, error)
 	HandleResponseBodyComplete(ctx context.Context, reqCtx *RequestContext) (*RequestContext, error)
 	GetRandomPod() *backend.Pod
@@ -123,7 +123,7 @@ const (
 	HeaderRequestResponseComplete    StreamRequestState = 1
 	BodyRequestResponsesComplete     StreamRequestState = 2
 	TrailerRequestResponsesComplete  StreamRequestState = 3
-	ResponseRecieved                 StreamRequestState = 4
+	ResponseReceived                 StreamRequestState = 4
 	HeaderResponseResponseComplete   StreamRequestState = 5
 	BodyResponseResponsesComplete    StreamRequestState = 6
 	TrailerResponseResponsesComplete StreamRequestState = 7
@@ -253,7 +253,7 @@ func (s *StreamingServer) Process(srv extProcPb.ExternalProcessor_ProcessServer)
 					loggerTrace.Info("model server is streaming response")
 				}
 			}
-			reqCtx.RequestState = ResponseRecieved
+			reqCtx.RequestState = ResponseReceived
 
 			var responseErr error
 			reqCtx, responseErr = s.HandleResponseHeaders(ctx, reqCtx, v)
@@ -379,7 +379,7 @@ func (r *RequestContext) updateStateAndSendIfNeeded(srv extProcPb.ExternalProces
 			return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
 		}
 	}
-	if r.RequestState == ResponseRecieved && r.respHeaderResp != nil {
+	if r.RequestState == ResponseReceived && r.respHeaderResp != nil {
 		loggerTrace.Info("Sending response header response", "obj", r.respHeaderResp)
 		if err := srv.Send(r.respHeaderResp); err != nil {
 			return status.Errorf(codes.Unknown, "failed to send response back to Envoy: %v", err)
diff --git a/pkg/epp/requestcontrol/director.go b/pkg/epp/requestcontrol/director.go
@@ -66,7 +66,7 @@ func NewDirectorWithConfig(datastore Datastore, scheduler Scheduler, saturationD
 		scheduler:                    scheduler,
 		saturationDetector:           saturationDetector,
 		preRequestPlugins:            config.preRequestPlugins,
-		postResponseRecievedPlugins:  config.postResponseRecievedPlugins,
+		postResponseReceivedPlugins:  config.postResponseReceivedPlugins,
 		postResponseStreamingPlugins: config.postResponseStreamingPlugins,
 		postResponseCompletePlugins:  config.postResponseCompletePlugins,
 		defaultPriority:              0, // define default priority explicitly
@@ -79,7 +79,7 @@ type Director struct {
 	scheduler                    Scheduler
 	saturationDetector           SaturationDetector
 	preRequestPlugins            []PreRequest
-	postResponseRecievedPlugins  []PostResponseRecieved
+	postResponseReceivedPlugins  []PostResponseReceived
 	postResponseStreamingPlugins []PostResponseStreaming
 	postResponseCompletePlugins  []PostResponseComplete
 	// we just need a pointer to an int variable since priority is a pointer in InferenceObjective
@@ -282,16 +282,16 @@ func (d *Director) toSchedulerPodMetrics(pods []backendmetrics.PodMetrics) []sch
 	return pm
 }
 
-// HandleResponseRecieved is called when the first chunk of the response arrives.
-func (d *Director) HandleResponseRecieved(ctx context.Context, reqCtx *handlers.RequestContext) (*handlers.RequestContext, error) {
+// HandleResponseReceived is called when the first chunk of the response arrives.
+func (d *Director) HandleResponseReceived(ctx context.Context, reqCtx *handlers.RequestContext) (*handlers.RequestContext, error) {
 	response := &Response{
 		RequestId: reqCtx.Request.Headers[requtil.RequestIdHeaderKey],
 		Headers:   reqCtx.Response.Headers,
 	}
 
 	// TODO: to extend fallback functionality, handle cases where target pod is unavailable
 	// https://github.com/kubernetes-sigs/gateway-api-inference-extension/issues/1224
-	d.runPostResponseRecievedPlugins(ctx, reqCtx.SchedulingRequest, response, reqCtx.TargetPod)
+	d.runPostResponseReceivedPlugins(ctx, reqCtx.SchedulingRequest, response, reqCtx.TargetPod)
 
 	return reqCtx, nil
 }
@@ -347,13 +347,13 @@ func (d *Director) runPreRequestPlugins(ctx context.Context, request *scheduling
 	}
 }
 
-func (d *Director) runPostResponseRecievedPlugins(ctx context.Context, request *schedulingtypes.LLMRequest, response *Response, targetPod *backend.Pod) {
+func (d *Director) runPostResponseReceivedPlugins(ctx context.Context, request *schedulingtypes.LLMRequest, response *Response, targetPod *backend.Pod) {
 	loggerDebug := log.FromContext(ctx).V(logutil.DEBUG)
-	for _, plugin := range d.postResponseRecievedPlugins {
+	for _, plugin := range d.postResponseReceivedPlugins {
 		loggerDebug.Info("Running post-response plugin", "plugin", plugin.TypedName())
 		before := time.Now()
-		plugin.PostResponseRecieved(ctx, request, response, targetPod)
-		metrics.RecordPluginProcessingLatency(PostResponseRecievedExtensionPoint, plugin.TypedName().Type, plugin.TypedName().Name, time.Since(before))
+		plugin.PostResponseReceived(ctx, request, response, targetPod)
+		metrics.RecordPluginProcessingLatency(PostResponseReceivedExtensionPoint, plugin.TypedName().Type, plugin.TypedName().Name, time.Since(before))
 		loggerDebug.Info("Completed running post-response plugin successfully", "plugin", plugin.TypedName())
 	}
 }
diff --git a/pkg/epp/requestcontrol/director_test.go b/pkg/epp/requestcontrol/director_test.go
@@ -592,13 +592,13 @@ func TestGetRandomPod(t *testing.T) {
 	}
 }
 
-func TestDirector_HandleResponseRecieved(t *testing.T) {
-	pr1 := newTestPostResponseRecieved("pr1")
+func TestDirector_HandleResponseReceived(t *testing.T) {
+	pr1 := newTestPostResponseReceived("pr1")
 
 	ctx := logutil.NewTestLoggerIntoContext(context.Background())
 	ds := datastore.NewDatastore(t.Context(), nil)
 	mockSched := &mockScheduler{}
-	director := NewDirectorWithConfig(ds, mockSched, nil, NewConfig().WithPostResponseRecievedPlugins(pr1))
+	director := NewDirectorWithConfig(ds, mockSched, nil, NewConfig().WithPostResponseReceivedPlugins(pr1))
 
 	reqCtx := &handlers.RequestContext{
 		Request: &handlers.Request{
@@ -613,7 +613,7 @@ func TestDirector_HandleResponseRecieved(t *testing.T) {
 		TargetPod: &backend.Pod{NamespacedName: types.NamespacedName{Namespace: "namespace1", Name: "test-pod-name"}},
 	}
 
-	_, err := director.HandleResponseRecieved(ctx, reqCtx)
+	_, err := director.HandleResponseReceived(ctx, reqCtx)
 	if err != nil {
 		t.Fatalf("HandleResponse() returned unexpected error: %v", err)
 	}
@@ -702,12 +702,12 @@ func TestDirector_HandleResponseComplete(t *testing.T) {
 }
 
 const (
-	testPostResponseRecievedType = "test-post-response"
+	testPostResponseReceivedType = "test-post-response"
 	testPostStreamingType        = "test-post-streaming"
 	testPostCompleteType         = "test-post-complete"
 )
 
-type testPostResponseRecieved struct {
+type testPostResponseReceived struct {
 	tn                      plugins.TypedName
 	lastRespOnResponse      *Response
 	lastTargetPodOnResponse string
@@ -725,9 +725,9 @@ type testPostResponseComplete struct {
 	lastTargetPodOnComplete string
 }
 
-func newTestPostResponseRecieved(name string) *testPostResponseRecieved {
-	return &testPostResponseRecieved{
-		tn: plugins.TypedName{Type: testPostResponseRecievedType, Name: name},
+func newTestPostResponseReceived(name string) *testPostResponseReceived {
+	return &testPostResponseReceived{
+		tn: plugins.TypedName{Type: testPostResponseReceivedType, Name: name},
 	}
 }
 
@@ -743,7 +743,7 @@ func newTestPostResponseComplete(name string) *testPostResponseComplete {
 	}
 }
 
-func (p *testPostResponseRecieved) TypedName() plugins.TypedName {
+func (p *testPostResponseReceived) TypedName() plugins.TypedName {
 	return p.tn
 }
 
@@ -755,7 +755,7 @@ func (p *testPostResponseComplete) TypedName() plugins.TypedName {
 	return p.tn
 }
 
-func (p *testPostResponseRecieved) PostResponseRecieved(_ context.Context, _ *schedulingtypes.LLMRequest, response *Response, targetPod *backend.Pod) {
+func (p *testPostResponseReceived) PostResponseReceived(_ context.Context, _ *schedulingtypes.LLMRequest, response *Response, targetPod *backend.Pod) {
 	p.lastRespOnResponse = response
 	p.lastTargetPodOnResponse = targetPod.NamespacedName.String()
 }
diff --git a/pkg/epp/requestcontrol/plugins.go b/pkg/epp/requestcontrol/plugins.go
@@ -26,7 +26,7 @@ import (
 
 const (
 	PreRequestExtensionPoint            = "PreRequest"
-	PostResponseRecievedExtensionPoint  = "PostResponseRecieved"
+	PostResponseReceivedExtensionPoint  = "PostResponseReceived"
 	PostResponseStreamingExtensionPoint = "PostResponseStreaming"
 	PostResponseCompleteExtensionPoint  = "PostResponseComplete"
 )
@@ -38,11 +38,11 @@ type PreRequest interface {
 	PreRequest(ctx context.Context, request *types.LLMRequest, schedulingResult *types.SchedulingResult, targetPort int)
 }
 
-// PostResponseRecieved is called by the director after a successful response is sent.
+// PostResponseReceived is called by the director after a successful response is sent.
 // The given pod argument is the pod that served the request.
-type PostResponseRecieved interface {
+type PostResponseReceived interface {
 	plugins.Plugin
-	PostResponseRecieved(ctx context.Context, request *types.LLMRequest, response *Response, targetPod *backend.Pod)
+	PostResponseReceived(ctx context.Context, request *types.LLMRequest, response *Response, targetPod *backend.Pod)
 }
 
 // PostResponseStreaming is called by the director after each chunk of streaming response is sent.
diff --git a/pkg/epp/requestcontrol/request_control_config.go b/pkg/epp/requestcontrol/request_control_config.go
@@ -24,7 +24,7 @@ import (
 func NewConfig() *Config {
 	return &Config{
 		preRequestPlugins:            []PreRequest{},
-		postResponseRecievedPlugins:  []PostResponseRecieved{},
+		postResponseReceivedPlugins:  []PostResponseReceived{},
 		postResponseStreamingPlugins: []PostResponseStreaming{},
 		postResponseCompletePlugins:  []PostResponseComplete{},
 	}
@@ -33,7 +33,7 @@ func NewConfig() *Config {
 // Config provides a configuration for the requestcontrol plugins.
 type Config struct {
 	preRequestPlugins            []PreRequest
-	postResponseRecievedPlugins  []PostResponseRecieved
+	postResponseReceivedPlugins  []PostResponseReceived
 	postResponseStreamingPlugins []PostResponseStreaming
 	postResponseCompletePlugins  []PostResponseComplete
 }
@@ -47,8 +47,8 @@ func (c *Config) WithPreRequestPlugins(plugins ...PreRequest) *Config {
 
 // WithPostResponsePlugins sets the given plugins as the PostResponse plugins.
 // If the Config has PostResponse plugins already, this call replaces the existing plugins with the given ones.
-func (c *Config) WithPostResponseRecievedPlugins(plugins ...PostResponseRecieved) *Config {
-	c.postResponseRecievedPlugins = plugins
+func (c *Config) WithPostResponseReceivedPlugins(plugins ...PostResponseReceived) *Config {
+	c.postResponseReceivedPlugins = plugins
 	return c
 }
 
@@ -75,8 +75,8 @@ func (c *Config) AddPlugins(pluginObjects ...plugins.Plugin) {
 		if preRequestPlugin, ok := plugin.(PreRequest); ok {
 			c.preRequestPlugins = append(c.preRequestPlugins, preRequestPlugin)
 		}
-		if postResponseRecievedPlugin, ok := plugin.(PostResponseRecieved); ok {
-			c.postResponseRecievedPlugins = append(c.postResponseRecievedPlugins, postResponseRecievedPlugin)
+		if postResponseReceivedPlugin, ok := plugin.(PostResponseReceived); ok {
+			c.postResponseReceivedPlugins = append(c.postResponseReceivedPlugins, postResponseReceivedPlugin)
 		}
 		if postResponseStreamingPlugin, ok := plugin.(PostResponseStreaming); ok {
 			c.postResponseStreamingPlugins = append(c.postResponseStreamingPlugins, postResponseStreamingPlugin)
diff --git a/pkg/epp/server/server_test.go b/pkg/epp/server/server_test.go
@@ -181,7 +181,7 @@ func (ts *testDirector) HandleRequest(ctx context.Context, reqCtx *handlers.Requ
 	return reqCtx, nil
 }
 
-func (ts *testDirector) HandleResponseRecieved(ctx context.Context, reqCtx *handlers.RequestContext) (*handlers.RequestContext, error) {
+func (ts *testDirector) HandleResponseReceived(ctx context.Context, reqCtx *handlers.RequestContext) (*handlers.RequestContext, error) {
 	return reqCtx, nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ func (s StreamingServer) HandleResponseHeaders(ctx context.Context, reqCtx Req`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`
`96`		`- reqCtx, err := s.director.HandleResponseRecieved(ctx, reqCtx)`
	`96`	`+ reqCtx, err := s.director.HandleResponseReceived(ctx, reqCtx)`
`97`	`97`
`98`	`98`	`return reqCtx, err`
`99`	`99`	`}`
Original file line number	Diff line number	Diff line change
`@@ -592,13 +592,13 @@ func TestGetRandomPod(t *testing.T) {`
`592`	`592`	`}`
`593`	`593`	`}`
`594`	`594`
`595`		`-func TestDirector_HandleResponseRecieved(t *testing.T) {`
`596`		`- pr1 := newTestPostResponseRecieved("pr1")`
	`595`	`+func TestDirector_HandleResponseReceived(t *testing.T) {`
	`596`	`+ pr1 := newTestPostResponseReceived("pr1")`
`597`	`597`
`598`	`598`	`ctx := logutil.NewTestLoggerIntoContext(context.Background())`
`599`	`599`	`ds := datastore.NewDatastore(t.Context(), nil)`
`600`	`600`	`mockSched := &mockScheduler{}`
`601`		`- director := NewDirectorWithConfig(ds, mockSched, nil, NewConfig().WithPostResponseRecievedPlugins(pr1))`
	`601`	`+ director := NewDirectorWithConfig(ds, mockSched, nil, NewConfig().WithPostResponseReceivedPlugins(pr1))`
`602`	`602`
`603`	`603`	`reqCtx := &handlers.RequestContext{`
`604`	`604`	`Request: &handlers.Request{`
`@@ -613,7 +613,7 @@ func TestDirector_HandleResponseRecieved(t *testing.T) {`
`613`	`613`	`TargetPod: &backend.Pod{NamespacedName: types.NamespacedName{Namespace: "namespace1", Name: "test-pod-name"}},`
`614`	`614`	`}`
`615`	`615`
`616`		`- _, err := director.HandleResponseRecieved(ctx, reqCtx)`
	`616`	`+ _, err := director.HandleResponseReceived(ctx, reqCtx)`
`617`	`617`	`if err != nil {`
`618`	`618`	`t.Fatalf("HandleResponse() returned unexpected error: %v", err)`
`619`	`619`	`}`
`@@ -702,12 +702,12 @@ func TestDirector_HandleResponseComplete(t *testing.T) {`
`702`	`702`	`}`
`703`	`703`
`704`	`704`	`const (`
`705`		`- testPostResponseRecievedType = "test-post-response"`
	`705`	`+ testPostResponseReceivedType = "test-post-response"`
`706`	`706`	`testPostStreamingType = "test-post-streaming"`
`707`	`707`	`testPostCompleteType = "test-post-complete"`
`708`	`708`	`)`
`709`	`709`
`710`		`-type testPostResponseRecieved struct {`
	`710`	`+type testPostResponseReceived struct {`
`711`	`711`	`tn plugins.TypedName`
`712`	`712`	`lastRespOnResponse *Response`
`713`	`713`	`lastTargetPodOnResponse string`
`@@ -725,9 +725,9 @@ type testPostResponseComplete struct {`
`725`	`725`	`lastTargetPodOnComplete string`
`726`	`726`	`}`
`727`	`727`
`728`		`-func newTestPostResponseRecieved(name string) *testPostResponseRecieved {`
`729`		`- return &testPostResponseRecieved{`
`730`		`- tn: plugins.TypedName{Type: testPostResponseRecievedType, Name: name},`
	`728`	`+func newTestPostResponseReceived(name string) *testPostResponseReceived {`
	`729`	`+ return &testPostResponseReceived{`
	`730`	`+ tn: plugins.TypedName{Type: testPostResponseReceivedType, Name: name},`
`731`	`731`	`}`
`732`	`732`	`}`
`733`	`733`
`@@ -743,7 +743,7 @@ func newTestPostResponseComplete(name string) *testPostResponseComplete {`
`743`	`743`	`}`
`744`	`744`	`}`
`745`	`745`
`746`		`-func (p *testPostResponseRecieved) TypedName() plugins.TypedName {`
	`746`	`+func (p *testPostResponseReceived) TypedName() plugins.TypedName {`
`747`	`747`	`return p.tn`
`748`	`748`	`}`
`749`	`749`
`@@ -755,7 +755,7 @@ func (p *testPostResponseComplete) TypedName() plugins.TypedName {`
`755`	`755`	`return p.tn`
`756`	`756`	`}`
`757`	`757`
`758`		`-func (p testPostResponseRecieved) PostResponseRecieved(_ context.Context, _ schedulingtypes.LLMRequest, response Response, targetPod backend.Pod) {`
	`758`	`+func (p testPostResponseReceived) PostResponseReceived(_ context.Context, _ schedulingtypes.LLMRequest, response Response, targetPod backend.Pod) {`
`759`	`759`	`p.lastRespOnResponse = response`
`760`	`760`	`p.lastTargetPodOnResponse = targetPod.NamespacedName.String()`
`761`	`761`	`}`
Original file line number	Diff line number	Diff line change
`@@ -181,7 +181,7 @@ func (ts testDirector) HandleRequest(ctx context.Context, reqCtx handlers.Requ`
`181`	`181`	`return reqCtx, nil`
`182`	`182`	`}`
`183`	`183`
`184`		`-func (ts testDirector) HandleResponseRecieved(ctx context.Context, reqCtx handlers.RequestContext) (*handlers.RequestContext, error) {`
	`184`	`+func (ts testDirector) HandleResponseReceived(ctx context.Context, reqCtx handlers.RequestContext) (*handlers.RequestContext, error) {`
`185`	`185`	`return reqCtx, nil`
`186`	`186`	`}`
`187`	`187`