updated conversion

Author: capri-xiyue

apix/v1alpha2/inferencepool_conversion.go

@@ -42,7 +42,7 @@ func (src *InferencePool) ConvertTo(dst *v1.InferencePool) error {
 	dst.TypeMeta = src.TypeMeta
 	dst.ObjectMeta = src.ObjectMeta
 	dst.Spec.TargetPorts = []v1.Port{{Number: v1.PortNumber(int32(src.Spec.TargetPortNumber))}}
-	dst.Spec.ExtensionRef = *v1Extension
+	dst.Spec.ExtensionRef = v1Extension
 	dst.Status = *v1Status
 	if src.Spec.Selector != nil {
 		dst.Spec.Selector.MatchLabels = make(map[v1.LabelKey]v1.LabelValue, len(src.Spec.Selector))
@@ -69,7 +69,7 @@ func (dst *InferencePool) ConvertFrom(src *v1.InferencePool) error {
 	dst.TypeMeta = src.TypeMeta
 	dst.ObjectMeta = src.ObjectMeta
 	dst.Spec.TargetPortNumber = int32(src.Spec.TargetPorts[0].Number)
-	dst.Spec.ExtensionRef = *extensionRef
+	dst.Spec.ExtensionRef = extensionRef
 	dst.Status = *status
 	if src.Spec.Selector.MatchLabels != nil {
 		dst.Spec.Selector = make(map[LabelKey]LabelValue, len(src.Spec.Selector.MatchLabels))
@@ -102,34 +102,28 @@ func convertStatusFromV1(src *v1.InferencePoolStatus) (*InferencePoolStatus, err
 	return convert[InferencePoolStatus](u)
 }
 
-func convertExtensionRefToV1(src *Extension) (*v1.Extension, error) {
-	if src == nil {
-		return nil, nil
-	}
+func convertExtensionRefToV1(src *Extension) (v1.Extension, error) {
 	u, err := toUnstructured(src)
 	if err != nil {
-		return nil, err
+		return v1.Extension{}, err
 	}
 	out, err := convert[v1.Extension](u)
 	if err != nil {
-		return nil, err
+		return v1.Extension{}, err
 	}
-	return out, nil
+	return *out, nil
 }
 
-func convertExtensionRefFromV1(src *v1.Extension) (*Extension, error) {
-	if src == nil {
-		return nil, nil
-	}
-	u, err := toUnstructured(src)
+func convertExtensionRefFromV1(src *v1.Extension) (Extension, error) {
+	u, err := toUnstructured(&src)
 	if err != nil {
-		return nil, err
+		return Extension{}, err
 	}
 	extension, err := convert[Extension](u)
 	if err != nil {
-		return nil, err
+		return Extension{}, err
 	}
-	return extension, nil
+	return *extension, nil
 }
 
 func toUnstructured(obj any) (*unstructured.Unstructured, error) {