Skip to content

Commit 1565f31

Browse files
authored
adds flag to disble pprof if desired, defaulted on (#1159)
1 parent 0b141c6 commit 1565f31

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

cmd/epp/runner/runner.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ var (
6565
"metricsPort",
6666
runserver.DefaultMetricsPort,
6767
"The metrics port")
68+
enablePprof = flag.Bool(
69+
"enablePprof",
70+
runserver.DefaultEnablePprof,
71+
"Enables pprof handlers. Defaults to true. Set to false to disable pprof handlers.")
6872
destinationEndpointHintKey = flag.String(
6973
"destinationEndpointHintKey",
7074
runserver.DefaultDestinationEndpointHintKey,
@@ -263,10 +267,14 @@ func (r *Runner) Run(ctx context.Context) error {
263267
setupLog.Error(err, "Failed to create controller manager")
264268
return err
265269
}
266-
err = setupPprofHandlers(mgr)
267-
if err != nil {
268-
setupLog.Error(err, "Failed to setup pprof handlers")
269-
return err
270+
271+
if *enablePprof {
272+
setupLog.Info("Enabling pprof handlers")
273+
err = setupPprofHandlers(mgr)
274+
if err != nil {
275+
setupLog.Error(err, "Failed to setup pprof handlers")
276+
return err
277+
}
270278
}
271279

272280
err = r.parseConfiguration(ctx)

config/charts/inferencepool/templates/epp-deployment.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ spec:
3535
- "9003"
3636
- -metricsPort
3737
- "9090"
38+
# https://pkg.go.dev/flag#hdr-Command_line_flag_syntax; space is only for non-bool flags
39+
- "-enablePprof={{ .Values.inferenceExtension.enablePprof }}"
3840
{{- if eq (.Values.inferencePool.modelServerType | default "vllm") "triton-tensorrt-llm" }}
3941
- -totalQueuedRequestsMetric
4042
- "nv_trt_llm_request_metrics{request_type=waiting}"

config/charts/inferencepool/values.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ inferenceExtension:
77
pullPolicy: Always
88
extProcPort: 9002
99
env: {}
10+
enablePprof: true # Enable pprof handlers for profiling and debugging
1011
# Example environment variables:
1112
# env:
1213
# KV_CACHE_SCORE_WEIGHT: "1"

pkg/epp/server/runserver.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ const (
7272
DefaultRefreshPrometheusMetricsInterval = 5 * time.Second // default for --refreshPrometheusMetricsInterval
7373
DefaultSecureServing = true // default for --secureServing
7474
DefaultHealthChecking = false // default for --healthChecking
75+
DefaultEnablePprof = true // default for --enablePprof
7576
DefaultTotalQueuedRequestsMetric = "vllm:num_requests_waiting" // default for --totalQueuedRequestsMetric
7677
DefaultKvCacheUsagePercentageMetric = "vllm:gpu_cache_usage_perc" // default for --kvCacheUsagePercentageMetric
7778
DefaultLoraInfoMetric = "vllm:lora_requests_info" // default for --loraInfoMetric

0 commit comments

Comments
 (0)