Skip to content

Commit 1d47648

Browse files
committed
change inferencepool ut temporarily
1 parent ea06f15 commit 1d47648

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

pkg/epp/controller/inferencepool_reconciler_test.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,9 +220,12 @@ func TestXInferencePoolReconciler(t *testing.T) {
220220
Version: v1alpha2.GroupVersion.Version,
221221
Kind: "InferencePool",
222222
}
223+
//TODO: change targetport to 8080
223224
pool1 := utiltest.MakeXInferencePool("pool1").
224225
Namespace("pool1-ns").
225226
Selector(selector_v1).
227+
TargetPortNumber(0).ObjRef()
228+
pool2 := utiltest.MakeXInferencePool("pool2").Namespace("pool2-ns").ObjRef()
226229
ExtensionRef("epp-service").
227230
TargetPortNumber(8080).ObjRef()
228231
pool2 := utiltest.MakeXInferencePool("pool2").Namespace("pool2-ns").ExtensionRef("epp-service").ObjRef()
@@ -324,11 +327,10 @@ func xDiffStore(t *testing.T, datastore datastore.Datastore, params xDiffStorePa
324327
if gotPool == nil && params.wantPool == nil {
325328
return ""
326329
}
327-
gotXPool := &v1alpha2.InferencePool{}
328330

329-
err := gotXPool.ConvertFrom(gotPool)
331+
gotXPool, err := v1alpha2.ConvertFrom(gotPool)
330332
if err != nil {
331-
t.Fatalf("failed to convert InferencePool to XInferencePool: %v", err)
333+
t.Fatalf("failed to convert unstructured to InferencePool: %v", err)
332334
}
333335
if diff := cmp.Diff(params.wantPool, gotXPool); diff != "" {
334336
return "pool:" + diff

0 commit comments

Comments
 (0)