Skip to content

Commit 2d4a599

Browse files
committed
fixed kubectl cli linter
1 parent 357b96f commit 2d4a599

File tree

5 files changed

+8
-13
lines changed

5 files changed

+8
-13
lines changed

api/v1/inferencepool_types.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,19 +70,18 @@ type InferencePoolSpec struct {
7070
// +kubebuilder:validation:MaxItems=1
7171
// +listType=map
7272
// +listMapKey=number
73+
// +required
7374
TargetPorts []Port `json:"targetPorts"`
7475

7576
// Extension configures an endpoint picker as an extension service.
7677
// +optional
77-
ExtensionRef *Extension `json:"extensionRef,omitempty,omitzero"`
78+
ExtensionRef Extension `json:"extensionRef,omitempty,omitzero"`
7879
}
7980

8081
type Port struct {
8182
// Number defines the port number to access the selected model server Pods.
8283
// The number must be in the range 1 to 65535.
8384
//
84-
// +kubebuilder:validation:Minimum=1
85-
// +kubebuilder:validation:Maximum=65535
8685
// +kubebuilder:validation:Required
8786
Number PortNumber `json:"number"`
8887
}

api/v1/zz_generated.deepcopy.go

Lines changed: 1 addition & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apix/v1alpha2/inferencepool_conversion.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ func (src *InferencePool) ConvertTo(dst *v1.InferencePool) error {
4242
dst.TypeMeta = src.TypeMeta
4343
dst.ObjectMeta = src.ObjectMeta
4444
dst.Spec.TargetPorts = []v1.Port{{Number: v1.PortNumber(src.Spec.TargetPortNumber)}}
45-
dst.Spec.ExtensionRef = v1Extension
45+
dst.Spec.ExtensionRef = *v1Extension
4646
dst.Status = *v1Status
4747
if src.Spec.Selector != nil {
4848
dst.Spec.Selector.MatchLabels = make(map[v1.LabelKey]v1.LabelValue, len(src.Spec.Selector))
@@ -58,7 +58,7 @@ func (dst *InferencePool) ConvertFrom(src *v1.InferencePool) error {
5858
if src == nil {
5959
return errors.New("src cannot be nil")
6060
}
61-
extensionRef, err := convertExtensionRefFromV1(src.Spec.ExtensionRef)
61+
extensionRef, err := convertExtensionRefFromV1(&src.Spec.ExtensionRef)
6262
if err != nil {
6363
return err
6464
}

apix/v1alpha2/inferencepool_conversion_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
100100
},
101101
},
102102
TargetPorts: []v1.Port{{Number: v1.PortNumber(int32(8080))}},
103-
ExtensionRef: &v1.Extension{
103+
ExtensionRef: v1.Extension{
104104
Group: &v1Group,
105105
Kind: v1Kind,
106106
Name: "my-epp-service",
@@ -235,7 +235,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
235235
},
236236
},
237237
TargetPorts: []v1.Port{{Number: v1.PortNumber(int32(8080))}},
238-
ExtensionRef: &v1.Extension{
238+
ExtensionRef: v1.Extension{
239239
Group: &v1Group,
240240
Kind: v1Kind,
241241
Name: "my-epp-service",

pkg/epp/util/testing/wrappers.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ func (m *InferencePoolWrapper) TargetPorts(p int32) *InferencePoolWrapper {
206206
}
207207

208208
func (m *InferencePoolWrapper) ExtensionRef(name string) *InferencePoolWrapper {
209-
m.Spec.ExtensionRef = &v1.Extension{Name: v1.ObjectName(name)}
209+
m.Spec.ExtensionRef = v1.Extension{Name: v1.ObjectName(name)}
210210
return m
211211
}
212212

0 commit comments

Comments
 (0)