Skip to content

Commit 3f98291

Browse files
authored
Only create LOCALBIN directory when it does not exist (#1054)
The current code was calling mkdir -p without checking existance first. This would change the directory's mtime and cause all files underneath to become "older". Since they declare LOCALBIN directory as a dependency, they would be downloaded/rebuilt more frequently than needed. Signed-off-by: Etai Lev Ran <[email protected]>
1 parent 8d391ee commit 3f98291

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ release: artifacts release-quickstart verify test # Create a release.
337337
## Location to install dependencies to
338338
LOCALBIN ?= $(shell pwd)/bin
339339
$(LOCALBIN):
340-
mkdir -p $(LOCALBIN)
340+
[ -d $@ ] || mkdir -p $@
341341

342342
## Tool Binaries
343343
KUBECTL ?= kubectl

0 commit comments

Comments
 (0)