Skip to content

Commit 418ec06

Browse files
committed
fetching proper base_ref.
1 parent ab66ff9 commit 418ec06

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/crd-validation.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,11 @@ jobs:
3030
3131
- name: Run CRD Validation Check
3232
run: |
33-
git fetch origin ${{ github.base_ref }}
34-
BASE_REF="origin/${{ github.base_ref }}"
33+
git fetch origin ${{ github.base_ref }}:upstream_base
34+
BASE_SHA=$(git rev-parse upstream_base)
35+
echo "Validating against Base SHA: $BASE_SHA (derived from ${{ github.base_ref }})"
3536
3637
FAILED=0
37-
3838
for crd in config/crd/bases/*.yaml; do
3939
if ! crdify "git://${BASE_REF}?path=$crd" "git://HEAD?path=$crd"; then
4040
echo "❌ Incompatible change detected in $crd"

0 commit comments

Comments
 (0)