change extension to be non-nil pointer

Author: capri-xiyue

api/v1/inferencepool_types.go

@@ -74,7 +74,7 @@ type InferencePoolSpec struct {
 	TargetPorts []Port `json:"targetPorts,omitempty"`
 
 	// Extension configures an endpoint picker as an extension service.
-	// +optional
+	// +required
 	ExtensionRef Extension `json:"extensionRef,omitempty,omitzero"`
 }
 

apix/v1alpha2/inferencepool_conversion.go

@@ -31,7 +31,7 @@ func (src *InferencePool) ConvertTo(dst *v1.InferencePool) error {
 	if dst == nil {
 		return errors.New("dst cannot be nil")
 	}
-	v1Extension, err := convertExtensionRefToV1(src.Spec.ExtensionRef)
+	v1Extension, err := convertExtensionRefToV1(&src.Spec.ExtensionRef)
 	if err != nil {
 		return err
 	}
@@ -69,7 +69,7 @@ func (dst *InferencePool) ConvertFrom(src *v1.InferencePool) error {
 	dst.TypeMeta = src.TypeMeta
 	dst.ObjectMeta = src.ObjectMeta
 	dst.Spec.TargetPortNumber = int32(src.Spec.TargetPorts[0].Number)
-	dst.Spec.ExtensionRef = extensionRef
+	dst.Spec.ExtensionRef = *extensionRef
 	dst.Status = *status
 	if src.Spec.Selector.MatchLabels != nil {
 		dst.Spec.Selector = make(map[LabelKey]LabelValue, len(src.Spec.Selector.MatchLabels))

apix/v1alpha2/inferencepool_conversion_test.go

@@ -60,7 +60,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
 						"app": "my-model-server",
 					},
 					TargetPortNumber: 8080,
-					ExtensionRef: &Extension{
+					ExtensionRef: Extension{
 						Group:       &group,
 						Kind:        &kind,
 						Name:        "my-epp-service",
@@ -273,7 +273,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
 						"app": "my-model-server",
 					},
 					TargetPortNumber: 8080,
-					ExtensionRef: &Extension{
+					ExtensionRef: Extension{
 						Group:       &group,
 						Kind:        &kind,
 						Name:        "my-epp-service",

apix/v1alpha2/inferencepool_types.go

@@ -70,8 +70,8 @@ type InferencePoolSpec struct {
 	TargetPortNumber int32 `json:"targetPortNumber"`
 
 	// Extension configures an endpoint picker as an extension service.
-	// +optional
-	ExtensionRef *Extension `json:"extensionRef,omitempty"`
+	// +required
+	ExtensionRef Extension `json:"extensionRef,omitempty"`
 }
 
 // Extension specifies how to configure an extension that runs the endpoint picker.

apix/v1alpha2/zz_generated.deepcopy.go

@@ -153,6 +153,7 @@ spec:
                 - number
                 x-kubernetes-list-type: map
             required:
+            - extensionRef
             - selector
             - targetPorts
             type: object

config/crd/bases/inference.networking.k8s.io_inferencepools.yaml

@@ -130,6 +130,7 @@ spec:
                 minimum: 1
                 type: integer
             required:
+            - extensionRef
             - selector
             - targetPortNumber
             type: object

config/crd/bases/inference.networking.x-k8s.io_inferencepools.yaml

@@ -252,7 +252,7 @@ func (m *XInferencePoolWrapper) TargetPortNumber(p int32) *XInferencePoolWrapper
 }
 
 func (m *XInferencePoolWrapper) ExtensionRef(name string) *XInferencePoolWrapper {
-	m.Spec.ExtensionRef = &v1alpha2.Extension{Name: v1alpha2.ObjectName(name)}
+	m.Spec.ExtensionRef = v1alpha2.Extension{Name: v1alpha2.ObjectName(name)}
 	return m
 }