Fail tests that have errors, don't just log the errors

shmuelk · shmuelk · commit 6794fe5cd93d · 2025-09-28T14:59:38.000+03:00
Signed-off-by: Shmuel Kallner &lt;kallner@il.ibm.com&gt;
diff --git a/pkg/epp/datastore/datastore_test.go b/pkg/epp/datastore/datastore_test.go
@@ -424,7 +424,7 @@ func TestPods(t *testing.T) {
 				gotPods = append(gotPods, pod)
 			}
 			if !cmp.Equal(gotPods, test.wantPods, cmpopts.SortSlices(func(a, b *corev1.Pod) bool { return a.Name < b.Name })) {
-				t.Logf("got (%v) != want (%v);", gotPods, test.wantPods)
+				t.Errorf("got (%v) != want (%v);", gotPods, test.wantPods)
 			}
 		})
 	}

Original file line number	Diff line number	Diff line change
`@@ -424,7 +424,7 @@ func TestPods(t *testing.T) {`
`424`	`424`	`gotPods = append(gotPods, pod)`
`425`	`425`	`}`
`426`	`426`	`if !cmp.Equal(gotPods, test.wantPods, cmpopts.SortSlices(func(a, b *corev1.Pod) bool { return a.Name < b.Name })) {`
`427`		`- t.Logf("got (%v) != want (%v);", gotPods, test.wantPods)`
	`427`	`+ t.Errorf("got (%v) != want (%v);", gotPods, test.wantPods)`
`428`	`428`	`}`
`429`	`429`	`})`
`430`	`430`	`}`