Skip to content

Commit 70e17e5

Browse files
Fix epp image and add placeholder docker repos for latency sidecars
1 parent 799883a commit 70e17e5

File tree

3 files changed

+45
-9
lines changed

3 files changed

+45
-9
lines changed

cmd/epp/runner/runner.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -749,7 +749,11 @@ type predictorRunnable struct {
749749

750750
func (p *predictorRunnable) Start(ctx context.Context) error {
751751
setupLog.Info("Starting latency predictor...")
752-
p.predictor.Start(ctx)
752+
if err := p.predictor.Start(ctx); err != nil {
753+
setupLog.Error(err, "Failed to start latency predictor")
754+
return err
755+
}
756+
setupLog.Info("Latency predictor started.")
753757
<-ctx.Done()
754758
setupLog.Info("Stopping latency predictor...")
755759
p.predictor.Stop()

config/charts/inferencepool/templates/epp-config.yaml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,16 @@ data:
4646
{{- .Values.inferenceExtension.pluginsCustomConfig | toYaml | nindent 2 }}
4747
{{- end }}
4848
---
49+
{{- if .Values.inferenceExtension.sidecar.enabled }}
50+
apiVersion: v1
51+
kind: ConfigMap
52+
metadata:
53+
name: {{ .Values.inferenceExtension.sidecar.configMap.name }}
54+
namespace: {{ .Release.Namespace }}
55+
data:
56+
{{- .Values.inferenceExtension.sidecar.configMap.data | toYaml | nindent 2 }}
57+
{{- end }}
58+
---
4959
{{- if .Values.inferenceExtension.latencyPredictor.enabled }}
5060
apiVersion: v1
5161
kind: ConfigMap
@@ -55,7 +65,7 @@ metadata:
5565
data:
5666
{{- range $key, $value := .Values.inferenceExtension.latencyPredictor.trainingServer.config }}
5767
{{ $key }}: {{ $value | quote }}
58-
{{- end }}
68+
{{- end }}
5969
---
6070
apiVersion: v1
6171
kind: ConfigMap

config/charts/inferencepool/values.yaml

Lines changed: 29 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
inferenceExtension:
22
replicas: 1
33
image:
4-
name: epp-wlp-latencypredictor-helm-v2
5-
hub: us-docker.pkg.dev/kaushikmitra-gke-dev/kaushikmitra-docker-repo
6-
tag: latest
4+
name: epp
5+
hub: us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension
6+
tag: main
77
pullPolicy: Always
88
extProcPort: 9002
99
env: []
@@ -12,6 +12,11 @@ inferenceExtension:
1212
extraContainerPorts: []
1313
# Define additional service ports
1414
extraServicePorts: []
15+
# extraServicePorts:
16+
# - name: http
17+
# port: 8081
18+
# protocol: TCP
19+
# targetPort: 8081
1520

1621
# This is the plugins configuration file.
1722
# pluginsCustomConfig:
@@ -39,6 +44,10 @@ inferenceExtension:
3944

4045
tolerations: []
4146

47+
# Sidecar configuration for EPP
48+
sidecar:
49+
enabled: false
50+
4251
# Monitoring configuration for EPP
4352
monitoring:
4453
interval: "10s"
@@ -69,7 +78,7 @@ inferenceExtension:
6978
# Training Server Configuration
7079
trainingServer:
7180
image:
72-
hub: us-docker.pkg.dev/kaushikmitra-gke-dev/kaushikmitra-docker-repo
81+
hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars
7382
name: latencypredictor-v3-training-server
7483
tag: latest
7584
pullPolicy: Always
@@ -110,7 +119,7 @@ inferenceExtension:
110119
count: 10
111120
startPort: 8001
112121
image:
113-
hub: us-docker.pkg.dev/kaushikmitra-gke-dev/kaushikmitra-docker-repo
122+
hub: path/to/your/docker/repo # NOTE: Update with your Docker repository path for sidecars
114123
name: latencypredictor-v3-prediction-server
115124
tag: latest
116125
pullPolicy: Always
@@ -168,12 +177,25 @@ provider:
168177
# Set to true if the cluster is an Autopilot cluster.
169178
autopilot: false
170179

180+
# Istio-specific configuration.
181+
# This block is only used if name is "istio".
182+
istio:
183+
destinationRule:
184+
# Provide a way to override the default calculated host
185+
host: ""
186+
# Optional: Enables customization of the traffic policy
187+
trafficPolicy: {}
188+
# connectionPool:
189+
# http:
190+
# maxRequestsPerConnection: 256000
191+
192+
# DEPRECATED and will be removed in v1.3. Instead, use `provider.istio.*`.
171193
istio:
172194
destinationRule:
173195
# Provide a way to override the default calculated host
174-
host: ""
196+
host: ""
175197
# Optional: Enables customization of the traffic policy
176198
trafficPolicy: {}
177199
# connectionPool:
178200
# http:
179-
# maxRequestsPerConnection: 256000
201+
# maxRequestsPerConnection: 256000

0 commit comments

Comments
 (0)