update

Author: Frapschen

config/charts/inferencepool/README.md

@@ -216,10 +216,20 @@ These are the options available to you with `provider.name` set to `istio`:
 | `istio.destinationRule.host`            | Custom host value for the destination rule. If not set this will use the default value which is derrived from the epp service name and release namespace to gerenate a valid service address. |
 | `istio.destinationRule.trafficPolicy.connectionPool`            | Configure the connectionPool level settings of the traffic policy |
 
-## OpenTelemetry
+#### OpenTelemetry
 
-The EndpointPicker supports OpenTelemetry-based tracing. To enable it, use `--set inferenceExtension.tracing.enabled=true`
-and configure the correct OpenTelemetry collector endpoint via `--set inferenceExtension.tracing.otelExporterEndpoint`.
+The EndpointPicker supports OpenTelemetry-based tracing. To enable trace collection, use the following configuration:
+```yaml
+inferenceExtension:
+  tracing:
+    enabled: true
+    otelExporterEndpoint: "http://localhost:4317"
+    sampling:
+      sampler: "parentbased_traceidratio"
+      samplerArg: "0.1"
+```
+Make sure that the `otelExporterEndpoint` points to your OpenTelemetry collector endpoint. 
+Current only the `parentbased_traceidratio` sampler is supported. You can adjust the base sampling rate using the `samplerArg` (e.g., 0.1 means 10% of traces will be sampled).
 
 ## Notes
 

pkg/common/telemetry.go

@@ -60,7 +60,7 @@ func InitTracing(ctx context.Context, logger logr.Logger) error {
 	traceExporter, err := initTraceExporter(ctx, logger)
 	if err != nil {
 		loggerWrap.Handle(fmt.Errorf("%s: %v", "init trace exporter fail", err))
-		return nil
+		return err
 	}
 
 	// Go SDK doesn't have an automatic sampler, handle manually