Skip to content

Commit 7efbadb

Browse files
authored
updated Makefile to allow configurable e2e image (#1092)
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent 582e5fa commit 7efbadb

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ PROJECT_DIR := $(shell dirname $(abspath $(lastword $(MAKEFILE_LIST))))
3838
# The path to the E2E manifest file. It can be overridden by setting the
3939
# E2E_MANIFEST_PATH environment variable. Note that HF_TOKEN must be set when using the GPU-based manifest.
4040
E2E_MANIFEST_PATH ?= config/manifests/vllm/sim-deployment.yaml
41+
# E2E_IMAGE specifies the image to be used when running e2e tests using make test-e2e.
42+
# it defaults to current image tag, but can be overwritten to test specific tags, releases, etc.
43+
E2E_IMAGE ?= $(IMAGE_TAG)
4144
# E2E_USE_KIND is a flag used in test-e2e target. when set to true it will load the e2e image into the kind cluster.
4245
# it is possible though to run e2e tests against clusters other than kind. in such a case, it is the user's responsibility to load
4346
# the image into the cluster.
@@ -142,7 +145,7 @@ test-integration: ## Run integration tests.
142145

143146
.PHONY: test-e2e
144147
test-e2e: ## Run end-to-end tests against an existing Kubernetes cluster.
145-
MANIFEST_PATH=$(PROJECT_DIR)/$(E2E_MANIFEST_PATH) E2E_IMAGE=$(IMAGE_TAG) USE_KIND=$(E2E_USE_KIND) ./hack/test-e2e.sh
148+
MANIFEST_PATH=$(PROJECT_DIR)/$(E2E_MANIFEST_PATH) E2E_IMAGE=$(E2E_IMAGE) USE_KIND=$(E2E_USE_KIND) ./hack/test-e2e.sh
146149

147150
.PHONY: lint
148151
lint: golangci-lint ## Run golangci-lint linter

0 commit comments

Comments
 (0)