Skip to content

Commit 85419bf

Browse files
committed
fixed ut
1 parent 14763aa commit 85419bf

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

api/v1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apix/v1alpha2/inferencepool_conversion.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ func convertExtensionRefToV1(src *Extension) (v1.EndpointPickerRef, error) {
120120
endpointPickerRef.PortNumber = &v1PortNumber
121121
}
122122
if src.FailureMode != nil {
123-
endpointPickerRef.FailureMode = v1.ExtensionFailureMode(*src.FailureMode)
123+
v1FailureMode := v1.ExtensionFailureMode(*src.FailureMode)
124+
endpointPickerRef.FailureMode = &v1FailureMode
124125
}
125126

126127
return endpointPickerRef, nil
@@ -144,8 +145,8 @@ func convertEndpointPickerRefFromV1(src *v1.EndpointPickerRef) (Extension, error
144145
portNumber := PortNumber(*src.PortNumber)
145146
extension.PortNumber = &portNumber
146147
}
147-
if src.FailureMode != "" {
148-
extensionFailureMode := ExtensionFailureMode(src.FailureMode)
148+
if src.FailureMode != nil {
149+
extensionFailureMode := ExtensionFailureMode(*src.FailureMode)
149150
extension.FailureMode = &extensionFailureMode
150151
}
151152
return extension, nil

apix/v1alpha2/inferencepool_conversion_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
105105
Kind: v1Kind,
106106
Name: "my-epp-service",
107107
PortNumber: &v1PortNumber,
108-
FailureMode: v1FailureMode,
108+
FailureMode: &v1FailureMode,
109109
},
110110
},
111111
Status: v1.InferencePoolStatus{
@@ -240,7 +240,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
240240
Kind: v1Kind,
241241
Name: "my-epp-service",
242242
PortNumber: &v1PortNumber,
243-
FailureMode: v1FailureMode,
243+
FailureMode: &v1FailureMode,
244244
},
245245
},
246246
Status: v1.InferencePoolStatus{

0 commit comments

Comments
 (0)