Skip to content

Commit 8809788

Browse files
authored
Try to polish the go doc comments for InferenceModelSpec (#948)
1 parent cd83f1c commit 8809788

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

api/v1alpha2/inferencemodel_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ type InferenceModelSpec struct {
6767
// ModelNames must be unique for a referencing InferencePool
6868
// (names can be reused for a different pool in the same cluster).
6969
// The modelName with the oldest creation timestamp is retained, and the incoming
70-
// InferenceModel is sets the Ready status to false with a corresponding reason.
70+
// InferenceModel's Ready status is set to false with a corresponding reason.
7171
// In the rare case of a race condition, one Model will be selected randomly to be considered valid, and the other rejected.
7272
// Names can be reserved without an underlying model configured in the pool.
7373
// This can be done by specifying a target model and setting the weight to zero,

config/crd/bases/inference.networking.x-k8s.io_inferencemodels.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ spec:
8888
ModelNames must be unique for a referencing InferencePool
8989
(names can be reused for a different pool in the same cluster).
9090
The modelName with the oldest creation timestamp is retained, and the incoming
91-
InferenceModel is sets the Ready status to false with a corresponding reason.
91+
InferenceModel's Ready status is set to false with a corresponding reason.
9292
In the rare case of a race condition, one Model will be selected randomly to be considered valid, and the other rejected.
9393
Names can be reserved without an underlying model configured in the pool.
9494
This can be done by specifying a target model and setting the weight to zero,

docs/proposals/002-api-proposal/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ type InferenceModelSpec struct {
236236
// ModelNames are expected to be unique for a specific InferencePool
237237
// (names can be reused for a different pool in the same cluster).
238238
// The modelName with the oldest creation timestamp is retained, and the incoming
239-
// InferenceModel is sets the Ready status to false with a corresponding reason.
239+
// InferenceModel's Ready status is set to false with a corresponding reason.
240240
// In the rare case of a race condition, one Model will be selected randomly to be considered valid, and the other rejected.
241241
// Names can be reserved without an underlying model configured in the pool.
242242
// This can be done by specifying a target model and setting the weight to zero,

site-src/reference/spec.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ _Appears in:_
211211

212212
| Field | Description | Default | Validation |
213213
| --- | --- | --- | --- |
214-
| `modelName` _string_ | ModelName is the name of the model as it will be set in the "model" parameter for an incoming request.<br />ModelNames must be unique for a referencing InferencePool<br />(names can be reused for a different pool in the same cluster).<br />The modelName with the oldest creation timestamp is retained, and the incoming<br />InferenceModel is sets the Ready status to false with a corresponding reason.<br />In the rare case of a race condition, one Model will be selected randomly to be considered valid, and the other rejected.<br />Names can be reserved without an underlying model configured in the pool.<br />This can be done by specifying a target model and setting the weight to zero,<br />an error will be returned specifying that no valid target model is found. | | MaxLength: 256 <br />Required: \{\} <br /> |
214+
| `modelName` _string_ | ModelName is the name of the model as it will be set in the "model" parameter for an incoming request.<br />ModelNames must be unique for a referencing InferencePool<br />(names can be reused for a different pool in the same cluster).<br />The modelName with the oldest creation timestamp is retained, and the incoming<br />InferenceModel's Ready status is set to false with a corresponding reason.<br />In the rare case of a race condition, one Model will be selected randomly to be considered valid, and the other rejected.<br />Names can be reserved without an underlying model configured in the pool.<br />This can be done by specifying a target model and setting the weight to zero,<br />an error will be returned specifying that no valid target model is found. | | MaxLength: 256 <br />Required: \{\} <br /> |
215215
| `criticality` _[Criticality](#criticality)_ | Criticality defines how important it is to serve the model compared to other models referencing the same pool.<br />Criticality impacts how traffic is handled in resource constrained situations. It handles this by<br />queuing or rejecting requests of lower criticality. InferenceModels of an equivalent Criticality will<br />fairly share resources over throughput of tokens. In the future, the metric used to calculate fairness,<br />and the proportionality of fairness will be configurable.<br />Default values for this field will not be set, to allow for future additions of new field that may 'one of' with this field.<br />Any implementations that may consume this field may treat an unset value as the 'Standard' range. | | Enum: [Critical Standard Sheddable] <br /> |
216216
| `targetModels` _[TargetModel](#targetmodel) array_ | TargetModels allow multiple versions of a model for traffic splitting.<br />If not specified, the target model name is defaulted to the modelName parameter.<br />modelName is often in reference to a LoRA adapter. | | MaxItems: 10 <br /> |
217217
| `poolRef` _[PoolObjectReference](#poolobjectreference)_ | PoolRef is a reference to the inference pool, the pool must exist in the same namespace. | | Required: \{\} <br /> |

0 commit comments

Comments
 (0)