Skip to content

Commit 8eb1e31

Browse files
authored
InferenceObjective: Updates PoolRef Group Version (#1346)
Signed-off-by: Daneyon Hansen <[email protected]>
1 parent 964fde6 commit 8eb1e31

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

apix/v1alpha2/inferenceobjective_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ type PoolObjectReference struct {
8787
// Group is the group of the referent.
8888
//
8989
// +optional
90-
// +kubebuilder:default="inference.networking.x-k8s.io"
90+
// +kubebuilder:default="inference.networking.k8s.io"
9191
Group Group `json:"group,omitempty"`
9292

9393
// Kind is kind of the referent. For example "InferencePool".

config/crd/bases/inference.networking.x-k8s.io_inferenceobjectives.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ spec:
8888
must exist in the same namespace.
8989
properties:
9090
group:
91-
default: inference.networking.x-k8s.io
91+
default: inference.networking.k8s.io
9292
description: Group is the group of the referent.
9393
maxLength: 253
9494
pattern: ^$|^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$

test/testdata/inferencepool-with-model-hermetic.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ spec:
1919
criticality: Critical
2020
poolRef:
2121
name: vllm-llama3-8b-instruct-pool
22-
group: inference.networking.k8s.io
2322
targetModels:
2423
- name: sql-lora-1fdg2
2524
weight: 100
@@ -32,7 +31,6 @@ metadata:
3231
spec:
3332
poolRef:
3433
name: vllm-llama3-8b-instruct-pool
35-
group: inference.networking.k8s.io
3634
targetModels:
3735
- name: sql-lora-1fdg3
3836
weight: 100
@@ -46,7 +44,6 @@ spec:
4644
criticality: Critical
4745
poolRef:
4846
name: vllm-llama3-8b-instruct-pool
49-
group: inference.networking.k8s.io
5047
targetModels:
5148
- name: my-model-12345
5249
weight: 100
@@ -60,4 +57,3 @@ spec:
6057
criticality: Critical
6158
poolRef:
6259
name: vllm-llama3-8b-instruct-pool
63-
group: inference.networking.k8s.io

0 commit comments

Comments
 (0)