Skip to content

Commit a4a6ab4

Browse files
authored
feat(conformance): loose the InferencePoolInvalidEPPService to only check httpRoute is accespted true. (#1131)
1 parent 4cd062a commit a4a6ab4

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

conformance/tests/basic/inferencepool_invalid_epp_service.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2323
"k8s.io/apimachinery/pkg/types"
2424
inferenceapi "sigs.k8s.io/gateway-api-inference-extension/api/v1alpha2"
25+
gatewayv1 "sigs.k8s.io/gateway-api/apis/v1"
2526
"sigs.k8s.io/gateway-api/conformance/utils/kubernetes"
2627
"sigs.k8s.io/gateway-api/conformance/utils/suite"
2728
"sigs.k8s.io/gateway-api/pkg/features"
@@ -56,7 +57,13 @@ var InferencePoolInvalidEPPService = suite.ConformanceTest{
5657
gwNN := types.NamespacedName{Name: "conformance-primary-gateway", Namespace: infraNamespace}
5758
poolNN := types.NamespacedName{Name: poolName, Namespace: appNamespace}
5859

59-
gwAddr := kubernetes.GatewayAndHTTPRoutesMustBeAccepted(t, s.Client, s.TimeoutConfig, s.ControllerName, kubernetes.NewGatewayRef(gwNN), routeNN)
60+
gwAddr := k8sutils.GetGatewayEndpoint(t, s.Client, s.TimeoutConfig, gwNN)
61+
acceptedCondition := metav1.Condition{
62+
Type: string(gatewayv1.RouteConditionAccepted),
63+
Status: metav1.ConditionTrue,
64+
Reason: string(gatewayv1.RouteReasonAccepted),
65+
}
66+
kubernetes.HTTPRouteMustHaveCondition(t, s.Client, s.TimeoutConfig, routeNN, gwNN, acceptedCondition)
6067
t.Run("InferecePool has a ResolvedRefs Condition with status False", func(t *testing.T) {
6168
acceptedCondition := metav1.Condition{
6269
Type: string(inferenceapi.InferencePoolConditionResolvedRefs), // Standard condition type

0 commit comments

Comments
 (0)